-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support Twins (NeurIPS2021) #989
Conversation
configs/twins/upernet_pcpvt_s_512x512_160k_ade20k_swin_setting.py
Outdated
Show resolved
Hide resolved
Hi @littleSunlxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your nice PR. The code looks good to me overall.
Just some minor comments.
Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add supported methods in readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* debug * debug * debug * this is a debug step, and needs to be recovered * need recover * git * debug * git * git * git * git * git * git * debug need recover * debug * git * debug * debug * debug * debug * debug * debug * debug * debug * debugf * debug * debug * debug * debug * debug * debug * debug * debug * git * git * git * use config small/base/large * debug * debug * git * debug * git * debug * debug * debug args * debug * debug * git * git * debug * git * git * git * git * git * debug * debug * git * debug * git * debug * debug * debug * debug * git * debug * git * git * debug * debug * git * git * git * git * debug * debug * debug * debug * git * debug * debug * git * git * debug * debug * git * debug * debug * debug * git * debug * debug * debug * Please enter the commit message for your changes. Lines starting * git * git * debug * debug * debug * git * git * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * git * debug * debug * debug * debug * debug * debug * debug * git * fix pre-commit error * fix error * git * git * git * git * git * git * debug * debug * debug * debug * debug * debug * git * debug * debug * debug * debug * debug * debug * debug * debug * debug * git * git * git * debug * debug * debug * git * git * git * git * git * git * git * git * git * debug * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * fix unittest error * fix config errors * fix twins2mmseg bug * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * git * fix init_weights() in twins.py * git * git * git * git * fix comment * fix comment * fix comment * fix comment * fix unit test coverage in TwinsPR * Add Twins README * Add Twins README * twins refactor * twins refactor * delete init_cfg in FFN * delete init_cfg in FFN * Update mmseg/models/backbones/twins.py * Update mmseg/models/backbones/twins.py * Update mmseg/models/backbones/twins.py Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn> * Update mmseg/models/backbones/twins.py * add conference name Co-authored-by: linxinyang <linxinyang@meituan.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>
Hi @littleSunlxy !First of all, we want to express our gratitude for your significant PR in the MMSeg project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
In this PR, we add Twins: Revisiting the Design of Spatial Attention in Vision Transformers (NeurIPS2021).
Paper: https://arxiv.org/pdf/2104.13840.pdf
Official Repo: https://github.com/Meituan-AutoML/Twins
Modification
add pcpvt/alt-gvt backbones and related modules (in gvt.py)
modified backbones init
Add configs and Readme for twins (in configs/twins/)
Update (2021-12-07)
init_cfg
works.