-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature for image demo. #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayuXu0
force-pushed
the
dev
branch
2 times, most recently
from
October 3, 2022 04:45
03dad65
to
01ba6a3
Compare
The tests failed because flake8 version is conflict with importlib_metadata. It have been fixed in #129 |
JiayuXu0
changed the title
Add the switch of whether to display the result.
Add feature for image inference demo.
Oct 4, 2022
JiayuXu0
changed the title
Add feature for image inference demo.
Add feature for image and video inference demo.
Oct 6, 2022
PeterH0323
requested changes
Oct 8, 2022
PeterH0323
requested changes
Oct 8, 2022
PeterH0323
requested changes
Oct 8, 2022
PeterH0323
requested changes
Oct 8, 2022
@JiayuXu0 The specific usage of the script that needs to be written in the pr message |
hhaAndroid
reviewed
Oct 8, 2022
hhaAndroid
reviewed
Oct 8, 2022
JiayuXu0
requested review from
PeterH0323 and
hhaAndroid
and removed request for
PeterH0323 and
hhaAndroid
October 9, 2022 14:04
PeterH0323
requested changes
Oct 9, 2022
JiayuXu0
force-pushed
the
dev
branch
3 times, most recently
from
October 10, 2022 01:57
0f0a1ca
to
7fef33c
Compare
PeterH0323
requested changes
Oct 10, 2022
hhaAndroid
reviewed
Oct 10, 2022
hhaAndroid
reviewed
Oct 10, 2022
hhaAndroid
changed the title
Add feature for image and video inference demo.
Add feature for image demo.
Oct 10, 2022
Closed
JiayuXu0
force-pushed
the
dev
branch
5 times, most recently
from
October 10, 2022 06:21
1d9e091
to
4bfd62f
Compare
hhaAndroid
reviewed
Oct 10, 2022
PeterH0323
requested changes
Oct 10, 2022
PeterH0323
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hhaAndroid
approved these changes
Oct 12, 2022
hhaAndroid
pushed a commit
to hhaAndroid/mmyolo
that referenced
this pull request
Oct 13, 2022
* Add the switch of whether to display the result. * Add the inference test of the images folder * Add video demo. * Add progress bar in image and video demo. * Add dir inference support. * Add url download support. * Add output path prompt at the end. * Modify the logic of saving results. * Update mmengine limit.
hhaAndroid
pushed a commit
to hhaAndroid/mmyolo
that referenced
this pull request
Oct 13, 2022
* Add the switch of whether to display the result. * Add the inference test of the images folder * Add video demo. * Add progress bar in image and video demo. * Add dir inference support. * Add url download support. * Add output path prompt at the end. * Modify the logic of saving results. * Update mmengine limit.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Add the switch of whether to display the result. * Add the inference test of the images folder * Add video demo. * Add progress bar in image and video demo. * Add dir inference support. * Add url download support. * Add output path prompt at the end. * Modify the logic of saving results. * Update mmengine limit.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Add the switch of whether to display the result. * Add the inference test of the images folder * Add video demo. * Add progress bar in image and video demo. * Add dir inference support. * Add url download support. * Add output path prompt at the end. * Modify the logic of saving results. * Update mmengine limit.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Add the switch of whether to display the result. * Add the inference test of the images folder * Add video demo. * Add progress bar in image and video demo. * Add dir inference support. * Add url download support. * Add output path prompt at the end. * Modify the logic of saving results. * Update mmengine limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
User has issue in the demo.
Modification
Add the switch of whether to display the result. The default value is False.
Add the inference test of the images folder.
Add progress bar in image demo.