-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pre commit hooks #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterH0323
approved these changes
Oct 8, 2022
hhaAndroid
reviewed
Oct 8, 2022
hhaAndroid
reviewed
Oct 8, 2022
JiayuXu0
force-pushed
the
fix-ci
branch
2 times, most recently
from
October 8, 2022 11:21
160ecbf
to
120ee3a
Compare
hhaAndroid
changed the title
Fix the version conflict in CircleCI.
Upgrade pre commit hooks
Oct 8, 2022
hhaAndroid
approved these changes
Oct 8, 2022
hhaAndroid
pushed a commit
to hhaAndroid/mmyolo
that referenced
this pull request
Oct 13, 2022
* Fix the version conflict in CircleCI * Update pre-commit config and add zh-cn version. * Add codespell ignore list. * Add codespell ignore list. * Add check copyright config.
hhaAndroid
pushed a commit
to hhaAndroid/mmyolo
that referenced
this pull request
Oct 13, 2022
* Fix the version conflict in CircleCI * Update pre-commit config and add zh-cn version. * Add codespell ignore list. * Add codespell ignore list. * Add check copyright config.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Fix the version conflict in CircleCI * Update pre-commit config and add zh-cn version. * Add codespell ignore list. * Add codespell ignore list. * Add check copyright config.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Fix the version conflict in CircleCI * Update pre-commit config and add zh-cn version. * Add codespell ignore list. * Add codespell ignore list. * Add check copyright config.
hhaAndroid
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Fix the version conflict in CircleCI * Update pre-commit config and add zh-cn version. * Add codespell ignore list. * Add codespell ignore list. * Add check copyright config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation to upgrade some versions of pre-commit hooks to latest is that
importlib-metadata v5.0.0
which removed deprecated endpoint breaks the flake8. More details at https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean/73932581#73932581.Refer to open-mmlab/mmengine#576
Modification
Upgrade some versions of pre-commit hooks.