This repository has been archived by the owner on Sep 30, 2022. It is now read-only.
brucks: rename the "brks" component to be "brucks" #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After hearing the 3rd person ask what "brks" stood for, I'm renaming this component to be "brucks" (because it uses a Bruck-based algorithm). (cherry picked from commit open-mpi/ompi@7850517)
|
Test PASSed. |
jsquyres
added a commit
that referenced
this pull request
Feb 10, 2016
brucks: rename the "brks" component to be "brucks"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hearing the 3rd person ask what "brks" stood for, I'm renaming
this component to be "brucks" (because it uses a Bruck-based algorithm).
(cherry picked from commit open-mpi/ompi@7850517)
@hppritcha I'm calling this a bug because the name is... confusing. Your call as to whether this goes in for v2.0.0 or later. As soon as #952 is approved, this component will be opal-ignored, anyway, so the end effect is harmless for v2.0.0 (meaning: don't merge this one before #952!).
@hjelmn please review