Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCX: compile errors with --enable-timing and --enable-mem-debug #6995

Closed
jsquyres opened this issue Sep 19, 2019 · 3 comments · Fixed by #7926
Closed

UCX: compile errors with --enable-timing and --enable-mem-debug #6995

jsquyres opened this issue Sep 19, 2019 · 3 comments · Fixed by #7926
Assignees
@yosefe @artpol84 @jladd-mlnx
Labels
bug Target: main Target: v4.0.x Target: v4.1.x

Comments

@jsquyres
Copy link
Member

Per https://www.mail-archive.com/devel@lists.open-mpi.org/msg20933.html, there are compile errors if one builds with UCX and --enable-timing or --enable-mem-debug.

These are apparently present on master and v4.0.x.
@artpol84
Copy link
Contributor

Thank you, @jsquyres
@karasevb please have a look. Start from "--enable-timings" as this is your code and should be easier to attack.

@karasevb
Copy link
Member

Refs #6072 relatively errors with --enable-timing

bertwesarg added a commit to bertwesarg/ompi that referenced this issue Jul 13, 2020
@bertwesarg
oshmem/mca/sshmem: Fix build with --enable-mem-debug
fb516fa 
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros
are also matched if they appear in references to members. Rename the
members to avoid this matching.

See open-mpi#6995

Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
@bertwesarg bertwesarg mentioned this issue Jul 13, 2020
Merged
bertwesarg added a commit to bertwesarg/ompi that referenced this issue Jul 13, 2020
@bertwesarg
oshmem/mca/sshmem: Fix build with --enable-mem-debug
3111877 
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros
are also matched if they appear in references to members. Rename the
members to avoid this matching.

See open-mpi#6995

Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
@bertwesarg bertwesarg mentioned this issue Jul 13, 2020
Closed
@jsquyres
Copy link
Member Author

See also #7926 and #7927.

@awlauria awlauria linked a pull request Oct 20, 2020 that will close this issue
oshmem/mca/sshmem: Fix build with --enable-mem-debug #7926
Merged
jsquyres pushed a commit to jsquyres/ompi that referenced this issue Oct 20, 2020
@bertwesarg @jsquyres
oshmem/mca/sshmem: Fix build with --enable-mem-debug
5b3bc64 
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros
are also matched if they appear in references to members. Rename the
members to avoid this matching.

See open-mpi#6995

Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
@jsquyres jsquyres mentioned this issue Oct 20, 2020
Merged
devreal pushed a commit to devreal/ompi that referenced this issue Dec 21, 2020
@bertwesarg @devreal
oshmem/mca/sshmem: Fix build with --enable-mem-debug
bd378db 
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros
are also matched if they appear in references to members. Rename the
members to avoid this matching.

See open-mpi#6995

Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
(cherry picked from commit 3111877)
@devreal devreal mentioned this issue Dec 21, 2020
Merged
devreal pushed a commit to devreal/ompi that referenced this issue Dec 21, 2020
@bertwesarg @devreal
oshmem/mca/sshmem: Fix build with --enable-mem-debug
88c59bd 
`--enable-mem-debug` `#define`s `realloc`/`free` as macros, though macros
are also matched if they appear in references to members. Rename the
members to avoid this matching.

See open-mpi#6995

Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de>
(cherry picked from commit 3111877)
@devreal devreal mentioned this issue Dec 21, 2020
Merged
@it-is-a-robot it-is-a-robot mentioned this issue Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yosefe yosefe

@artpol84 artpol84

@jladd-mlnx jladd-mlnx

Labels
bug Target: main Target: v4.0.x Target: v4.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oshmem/mca/sshmem: Fix build with --enable-mem-debug bertwesarg/ompi
5 participants
@jsquyres @yosefe @artpol84 @jladd-mlnx @karasevb