-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shmem: rename realloc/free in segment_allocator to avoid name clash with memory debugging #7927
Conversation
…ith memory debugging Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
@devreal could you figure out why the jenkins build fails. I clicked everything through but could not found any error. |
Mhh, not sure why that fails. In the logs I see:
|
That's a weird one. Let's see if it was a transient error. bot:aws:retest |
Thanks @jsquyres, tests seem to have succeeded. |
@yosefe Could you please review this one? |
We hit this recently and applied a similar fix. Thanks for pushing it upstream. |
Unlikely as it may be, we could also prepend these with |
@bertwesarg @devreal Can you guys figure out which of this PR and #7926 should get merged? They're fairly straightforward and have been sitting around forever. Thanks! |
#7926 merged, so closing this. |
The tokens
realloc
andfree
are overridden by Open MPI's memory debugging facility, leading to build errors if enabled. This PR renames struct members in the shmemsegment_allocator
toreallocate
andrelease
to avoid the name clash.Fixes #7925
Signed-off-by: Joseph Schuchart schuchart@hlrs.de