Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shmem: rename realloc/free in segment_allocator to avoid name clash with memory debugging #7927

Closed
wants to merge 1 commit into from

Conversation

devreal
Copy link
Contributor

@devreal devreal commented Jul 13, 2020

The tokens realloc and free are overridden by Open MPI's memory debugging facility, leading to build errors if enabled. This PR renames struct members in the shmem segment_allocator to reallocate and release to avoid the name clash.

Fixes #7925

Signed-off-by: Joseph Schuchart schuchart@hlrs.de

…ith memory debugging

Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
@devreal devreal requested a review from yosefe July 13, 2020 06:26
@bertwesarg
Copy link
Member

@devreal could you figure out why the jenkins build fails. I clicked everything through but could not found any error.

@devreal
Copy link
Contributor Author

devreal commented Jul 15, 2020

Mhh, not sure why that fails. In the logs I see:

+ /bin/sh open-mpi-build-script.sh
open-mpi-build-script.sh: 1: open-mpi-build-script.sh: 500:: not found
Build step 'Execute shell' marked build as failure
Finished: FAILURE

@jsquyres
Copy link
Member

That's a weird one. Let's see if it was a transient error.

bot:aws:retest

@devreal
Copy link
Contributor Author

devreal commented Jul 16, 2020

Thanks @jsquyres, tests seem to have succeeded.

@devreal
Copy link
Contributor Author

devreal commented Aug 8, 2020

@yosefe Could you please review this one?

@awlauria
Copy link
Contributor

awlauria commented Oct 7, 2020

We hit this recently and applied a similar fix. Thanks for pushing it upstream.

@awlauria
Copy link
Contributor

awlauria commented Oct 7, 2020

Unlikely as it may be, we could also prepend these with oshmen_ or similar to make it more bullet-proof.

@jsquyres
Copy link
Member

@bertwesarg @devreal Can you guys figure out which of this PR and #7926 should get merged? They're fairly straightforward and have been sitting around forever. Thanks!

@awlauria
Copy link
Contributor

#7926 merged, so closing this.

@awlauria awlauria closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling memory debugging breaks shmem build
5 participants