-
Notifications
You must be signed in to change notification settings - Fork 894
Address Github issue #11532 by translating legacy parameters for direct launches #11921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated my v5.0.x branch correctly and re-opened this PR. |
my guess is a submodule update is needed for v5 |
Yeah, this is failing because it is looking at old PMIx code. Commit #11920 and then rebase this and it should be okay. |
Looks like I don't have #11920 underneath this in my 5.0.x branch yet. I'll pull it in and rebase, then force push this. |
You shouldn't need to rebase. bot:retest |
@qkoziol the PR to v5 was merged, let's give this another ci run before closing/force pushing. |
and too late.. |
Please do another force push to resolve the conflicts. |
@qkoziol Please stop closing PR's and opening new PR's. Please just fix your original PR. |
Looks like "syncing my branch" in Github is what keeps closing the PR @jsquyres |
Hahah! You anticipated my comment. 😄 |
@qkoziol I don't know what you're doing, but if you bring the branch on this PR up to the HEAD of the target branch of this PR (i.e., |
Not certain ¯\(ツ)/¯ I'm just going to stay away from the "sync branch" option, when the branch has an open PR... |
FYI, new PR: #11923 |
Borrow code from the OMPI schizo module in PRRTE that translates legacy MCA parameters when an application is direct launched (PRRTE will translate legacy parameters when natively launched).
(cherry picked from commit 5d236e9)