Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Github issue #11532 by translating legacy parameters for direct launches #11923

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

qkoziol
Copy link
Contributor

@qkoziol qkoziol commented Sep 11, 2023

Borrow code from the OMPI schizo module in PRRTE that translates legacy MCA parameters when an application is direct launched (PRRTE will translate legacy parameters when natively launched).

(cherry picked from commit 5d236e9)

…for direct launches

Borrow code from the OMPI schizo module in PRRTE that translates legacy
MCA parameters when an application is direct launched (PRRTE will translate
legacy parameters when natively launched).

Signed-off-by: Quincey Koziol <qkoziol@amazon.com>
(cherry picked from commit 5d236e9)
Signed-off-by: Quincey Koziol <qkoziol@amazon.com>
@qkoziol
Copy link
Contributor Author

qkoziol commented Sep 11, 2023

Also, for my future reference and possibly other devs' knowledge: when you are cherry-picking commit(s) from the OMPI main branch to a release branch, it's better to checkout the OMPI repo without the submodules (git clone ...), then immediately check out the release branch (git checkout <branch>) and update the submodules (with "git submodule update --init --recursive") and then cherry-pick the commit(s) to the branch (git cherry-pick -x -s <hash>) .

@awlauria
Copy link
Contributor

@qkoziol the problem with the original PR was not that you did anything wrong with the cherry-pick or the PR, it was because v5.0.0 did not have a submodule update merged in that this commit depends on. Had you included the submodule update in your pr, it would have been fine (and the last pr would have also been fine if you didn't try to rebase..not sure what happened there).

As it is now, we merged the submodule update, and things are happy.

Either way it works and it is fine - thanks for bringing these back.

@awlauria awlauria merged commit e533174 into open-mpi:v5.0.x Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants