Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.x: coll/ucc: add reduce scatter block #12897

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Sergei-Lebedev
Copy link
Contributor

Adding reduce scatter block to ucc coll component

Signed-off-by: Sergey Lebedev sergeyle@nvidia.com
bot:notacherrypick

@github-actions github-actions bot added this to the v4.1.7 milestone Oct 30, 2024
Signed-off-by: Sergey Lebedev <sergeyle@nvidia.com>
bot:notacherrypick
@jsquyres
Copy link
Member

@Sergei-Lebedev Is there a reason to add this to v4.1.x? The v4.1.x series is closing down -- we really don't want to accept new features. Instead, the goal should be to get new things into main + v5.0.x.

@Sergei-Lebedev
Copy link
Contributor Author

@Sergei-Lebedev Is there a reason to add this to v4.1.x? The v4.1.x series is closing down -- we really don't want to accept new features. Instead, the goal should be to get new things into main + v5.0.x.

coll ucc already has reduce scatter block in v5.0.x, but in HPCX we are still using v4.1.x. Maybe @janjust can add more details.

@janjust
Copy link
Contributor

janjust commented Oct 30, 2024

This is the only reason, we want to move onto v5.0.x but are not ready yet and HPC-X will ship with v4.1.x for at least another release cycle. And as far as I know same is true for HPC-SDK, they're still on v4.1.x

@jsquyres
Copy link
Member

Ok. This is entirely within your component, so... so be it.

But please move to v5.0.x as soon as you can. 😈

@jsquyres
Copy link
Member

bot:ompi:retest

@janjust
Copy link
Contributor

janjust commented Oct 30, 2024

Thank you 🙏

@jsquyres jsquyres merged commit 6b7e5d9 into open-mpi:v4.1.x Oct 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants