MCA variable scope and coll tuned rules file update onto v4.1.x #12928
+222
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2024 12:42
Teach the dynamic rules file reader to look for the alltoall_algorithm_max_requests tuning parameter. To keep the dynamic rules file format backward compatible the alltoall_algorithm_max_requests is optional. When not present in the rule definition the value of the corresponding MCA variable is used instead. Resolves open-mpi#12589 Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit 33f8c74)
the version identifier is optional but when provided it must have the following format and must appear on the first line.`rule-file-version-N` where N is an unsigned integer. Older versions of the parser will fall back to fixed decision mechanism when this line is present. Version 1 is the original format, Version 2 has support for optional coll_tuned_alltoall_algorithm_max_requests specification. Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit f6387a4)
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit 617e89d)
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: d3e0029: fix MCA variable scope in coll han
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
added 5 commits
November 20, 2024 13:16
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit 329ea0e)
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit fdf60ac)
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit 44e0436)
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface Signed-off-by: Burlen Loring <bloring@nvidia.com> (cherry picked from commit 75befb8)
Changes several variables scope from READONLY to ALL so that they can be set via MPI_T interface. Picks up a few instances that were not in main. bot:notacherrypick Signed-off-by: bloring <bloring@nvidia.com>
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: f7011c6: fix MCA variable scope in coll han
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
We were somewhat hoping that v4.1.7 would be the last release of the v4.1.x series. Is this functionality absolutely critical and needed in v4.1.x? |
|
I see. I was not aware. I want them on v4.1.x to be a part of the NVIDIA HPC-X release. HPC-X is the deployment vehicle for several of the systems I use. It sounds like there will be at least one more HPC-X release on v4.1.x branch. #12897. Could these be included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick MCA variable scope and coll tuned rules file update onto v4.1.x