Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6238 for v3.1.x #6455

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Fix 6238 for v3.1.x #6455

merged 2 commits into from
Mar 12, 2019

Conversation

hppritcha
Copy link
Member

Correct parsing of ppr directives

Needed to apply commit from PR #5778 to get this commit
from PR #6238 to apply cleanly.

Signed-off-by: Ralph Castain rhc@open-mpi.org
(cherry picked from commit b19e5ed)

Ralph Castain added 2 commits March 5, 2019 06:29
@hppritcha
Update mapping system
ebbd815 
Correctly transfer job-level mapping directives for dynamically spawned
jobs to the mapping system.

Signed-off-by: Ralph Castain <rhc@open-mpi.org>
(cherry picked from commit 45f23ca)
@hppritcha
Correct parsing of ppr directives
c7ccbe9 
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
(cherry picked from commit b19e5ed)
@hppritcha hppritcha requested a review from rhc54 March 5, 2019 13:59
rhc54
rhc54 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hppritcha !

@hppritcha
Copy link
Member Author

bot:mellanox:retest

@hppritcha
Copy link
Member Author

Mellanox seems to be having a bad day.

@hppritcha
Copy link
Member Author

@xinzhao3 could you get someone from Mellanox to investigate the CI failures? Seems to be impacting multiple PRs.

@jsquyres
Copy link
Member

jsquyres commented Mar 5, 2019

@hppritcha See #6414 (comment)

@jsquyres
Copy link
Member

bot:mellanox:retest

@jsquyres jsquyres added this to the v3.1.4 milestone Mar 12, 2019
@jsquyres jsquyres merged commit 7412e88 into open-mpi:v3.1.x Mar 12, 2019
@janjust janjust mentioned this pull request Jul 12, 2019
Merged
@hppritcha hppritcha deleted the topic/6238_for_v3.1.x branch October 29, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhc54 rhc54 rhc54 approved these changes

Assignees

@rhc54 rhc54

Labels
Target: v3.1.x
Projects
None yet
Milestone
v3.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@hppritcha @jsquyres @rhc54 @bwbarrett