v4.0.x OSC: Reset external request to NULL

[janjust]

Addresses issue #6552 (Not reproduced in master).
Reset external request to NULL to avoid double request completion.
Co-authored with Artem Polyakov artemp@mellanox.com

Signed-off-by: Tomislav Janjusic tomislavj@mellanox.com

[ibm-ompi]

The IBM CI (XL Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/e3f7a4c1da95c1a8ec079e09da7de012

[artpol84]

@yosefe
I think 2 things contributed to the issue

1. Rget/Rput were less tested than their non-request counterparts
2. There is some confusion regarding whether or not UCX will call the request cleanup function at ucp_request_release. It will not, but I used to think it will myself.

[jjhursey]

bot:ibm:xl:retest

[hppritcha]

I don't think the reference to #6455 is correct.

[hppritcha]

@janjust which issue is this PR suppose to fix?

[janjust]

@hppritcha my mistake, I corrected the reference. It fixes #6552

[hppritcha]

@yosefe could you review this?

[gpaulsen]

:bot:retest

[hppritcha]

ompi:bot:retest

[artpol84]

@jsquyres @hppritcha

conftest.c:343:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 char __malloc_initialize_hook ();
 ^~~~
conftest.c:352:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 main ()
 ^~~~
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /tmp/ccUlyi2d.o: in function `main':
conftest.c:(.text.startup+0x7): undefined reference to `__malloc_initialize_hook'
collect2: error: ld returned 1 exit status

This doesn't look like an issue on this PRs side.

[hppritcha]

try again
ompi:bot:retest

[hppritcha]

this PR is also hitting the flex problem:

configure:37017: WARNING: *** Could not find Flex on your system.
configure:37019: WARNING: *** Flex is required for developer builds of Open MPI.
configure:37021: WARNING: *** Other versions of Lex are not supported.
configure:37023: WARNING: *** YOU DO NOT NEED FLEX WHEN BUILDING DISTRIBUTION TARBALLS!
configure:37025: error: Cannot continue

[hppritcha]

bot:lanl:retest