Backport Collective changes from master to v4.1.x #7808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call of MPI_Allgatherv with sendbuf and sendtype parameters equal to MPI_IN_PLACE and NULL correspondingly, produces the segmentation fault. The problem is that sendtype is used even when sendbuf value is MPI_IN_PLACE. But according to the standard, sendtype and sendcount parameters should be ignored in this case. Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit b45e190) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
always initialize 'size'. Only the a2a_sched_diss() alltoall algorithm is impacted, and this algo is currently unused, so there is no need to backport nor update the NEWS file for now. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit ff48e92) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu> (cherry picked from commit 466217f) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Gcc 8 identified hb_tree_csearch() as an infinite recursion, and it turns out that we never call this function, anyway. So just remove it. Fixes open-mpi#5670. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 06c1bf7) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Implements recursive doubling algorithm for MPI_Iscan. The algorithm preserves order of operations so it can be used both by commutative and non-commutative operations. The MCA parameter coll_libnbc_iscan_algorithm was added for dynamic algorithm selection. Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit 3d43ff0) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Implements recursive doubling algorithm for MPI_Iexscan. The algorithm preserves order of operations so it can be used both by commutative and non-commutative operations. The MCA parameter 'coll_libnbc_iexscan_algorithm' was added for dynamic algorithm selection. Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit dfe203e) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Remove dead code that was causing warnings about unused static functions. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 2e24e6e) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
An implementation of R. Rabenseifner's algorithm for MPI_Ireduce.
This algorithm is a combination of a reduce-scatter implemented with recursive vector halving
and recursive distance doubling, followed either by a gather.
Limitations:
-- count >= 2^{\floor{\log_2 p}}
-- commutative operations only
-- intra-communicators only
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
(cherry picked from commit 7bd63e7)
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit b0429d2) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Implements recursive doubling algorithm for MPI_Iallgather. The algorithm can be used only for power-of-two number of processes. Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit a7386c1) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit 66182a2) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
An implementation of R. Rabenseifner's algorithm for MPI_Iallreduce.
This algorithm is a combination of a reduce-scatter implemented with recursive vector halving
and recursive distance doubling, followed either by an allgather.
Limitations:
-- count >= 2^{\floor{\log_2 p}}
-- commutative operations only
-- intra-communicators only
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
(cherry picked from commit 73e048b)
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit 8b511c7) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
1. Remove debug output in iallgather (I have forgotten to remove it). 2. Remove an incorrect comment in description of ibcast Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com> (cherry picked from commit 64abd0f) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Alex Anenkov <anenkov.ru@gmail.com> (cherry picked from commit 77d466e) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Valentin Petrov valentinp@mellanox.com (cherry picked from commit 6ea920e) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit 531171c) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Mikhail Brinskii <mikhailb@mellanox.com> (cherry picked from commit f2cbd48) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: William Zhang <wilzhang@amazon.com> (cherry picked from commit 5064040) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: William Zhang <wilzhang@amazon.com> cr https://code.amazon.com/reviews/CR-23837553 (cherry picked from commit 771f9c0) Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
force-pushed
the
backports/v4.1.x-collectives-updates
branch
from
587bd85 to
339ee63
Compare
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit f64c30e)
jsquyres
force-pushed
the
backports/v4.1.x-collectives-updates
branch
from
26487ae to
7987a7f
Compare
jsquyres
approved these changes
Jun 26, 2020
Member
Author
|
bot:aws:retest |
1 similar comment
Member
Author
|
bot:aws:retest |
Member
Author
|
bot:aws:retest Not sure what happened, SSL CA error (meaning curl couldn't read the local CA bundle, I think): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series backports all the significant changes from the collectives components from master to v4.1.x. The diff between master and v4.1.x are all repository-wide code cleanups that weren't worth pulling in.