v4.0.x: Bring fixes back from v4.1.x branch #8258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPI_Ialltoallw() and friends take a const MPI_Datatype types[] argument. In order to be able to call OBJ_RELEASE(types[0]), we used to simply drop the const modifier. This change make it right by introducing the OBJ_RELEASE_NO_NULLIFY(object) macro that no more set object = NULL if the object is freed. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit c49e5e5) (cherry picked from commit 129b5ee)
Fixes open-mpi#8195. This PR doesn't fix all the warnings from open-mpi#8195, but fixes many of them (e.g., I didn't get the "string might be truncated" warnings on my Mac). This is an adaptation of 14aa5fa from master; it drops some things that aren't relevant here on the v4.1.x branch and adds a few more warnings fixes that are relevant here on v4.1.x that aren't relevant on master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry-picked from 14aa5fa) (cherry picked from commit f9e2bf7)
Remove the pack/unpack pragma around net/if.h on MacOS, which was added to fix a bug in MacOS X 10.4.x on 64-bit platforms. The bug was fixed in Mac OS X 10.5.0 and, sometime in the last 11 years, compilers started emitting warnings about the fact that the Apple header stomped over the pragma pack settings from the workaround. We already don't support versions of MacOS earlier than 10.5, so there's no point in keeping the workaround. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit a25df3f) (cherry picked from commit f566613)
Open MPI doesn't support any transports on MacOS which require memory manager hooks. The memory patcher component uses the syscall interface, which has been deprecated in recent versions of MacOS. Since we don't need it and it emits warnings about deprecation, disable the memory patcher component on MacOS. Fixes open-mpi#5671 Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 19e16d5) (cherry picked from commit 8324b4e)
Only get the locality string and output binding message when requested Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 09e9fe0)
bosilca
approved these changes
Nov 26, 2020
rhc54
approved these changes
Nov 26, 2020
always initialize 'size'. Only the a2a_sched_diss() alltoall algorithm is impacted, and this algo is currently unused, so there is no need to backport nor update the NEWS file for now. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit ff48e92) Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit d9d84d5)
|
bot:ibm:retest |
gpaulsen
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently fixed a whole pile of warnings on the v4.1.x branch. Most of those warnings are also applicable to the v4.0.x branch. This PR therefore cherry picks commits from the following v4.1.x PRs:
These are cherry-picks from v4.1.x, which are, in turn, cherry-picks from master. I chose to cherry-pick directly from v4.1.x because there was a little bit of porting/adapting when cherry-picking from master to v4.1.x, and I thought it would just introduce more possibility for error if I had to do the same porting/adapting again (i.e., cherry-picking from master to v4.0.x). In this case, it seemed more straightforward / less error-prone to cherry-pick from v4.1.x to v4.0.x.
Because a cherry-pick of one of the commits from #7808 was added after this PR was created, this PR now fixes #8259.