v4.1.x: fix many warnings #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPI_Ialltoallw() and friends take a const MPI_Datatype types[] argument. In order to be able to call OBJ_RELEASE(types[0]), we used to simply drop the const modifier. This change make it right by introducing the OBJ_RELEASE_NO_NULLIFY(object) macro that no more set object = NULL if the object is freed. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit c49e5e5)
jsquyres
force-pushed
the
pr/v4.1.x/fix-warnings
branch
from
50ed871 to
dbaa448
Compare
Fixes open-mpi#8195. This PR doesn't fix all the warnings from open-mpi#8195, but fixes many of them (e.g., I didn't get the "string might be truncated" warnings on my Mac). This is an adaptation of 14aa5fa from master; it drops some things that aren't relevant here on the v4.1.x branch and adds a few more warnings fixes that are relevant here on v4.1.x that aren't relevant on master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry-picked from 14aa5fa)
jsquyres
force-pushed
the
pr/v4.1.x/fix-warnings
branch
from
dbaa448 to
f9e2bf7
Compare
rajachan
approved these changes
Nov 23, 2020
|
bot:ibm:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8195. This PR doesn't fix all the warnings from #8195, but
fixes many of them (e.g., I didn't get the "string might be truncated"
warnings on my Mac).
This is an adaptation of 14aa5fa from
master; it drops some things that aren't relevant here on the v4.1.x
branch and adds a few more warnings fixes that are relevant here on
v4.1.x that aren't relevant on master.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry-picked from 14aa5fa)