v4.1.x: Fix missed compiler warnings #8255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some "const"s that needed to be applied here on the v4.1.x branch, effectively by cherry-picking part of b65ec27 from master. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Remove the pack/unpack pragma around net/if.h on MacOS, which was added to fix a bug in MacOS X 10.4.x on 64-bit platforms. The bug was fixed in Mac OS X 10.5.0 and, sometime in the last 11 years, compilers started emitting warnings about the fact that the Apple header stomped over the pragma pack settings from the workaround. We already don't support versions of MacOS earlier than 10.5, so there's no point in keeping the workaround. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit a25df3f)
Open MPI doesn't support any transports on MacOS which require memory manager hooks. The memory patcher component uses the syscall interface, which has been deprecated in recent versions of MacOS. Since we don't need it and it emits warnings about deprecation, disable the memory patcher component on MacOS. Fixes open-mpi#5671 Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 19e16d5)
rajachan
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring over a few more compiler warnings fixes from master to finish cleaning up the v4.1.x warnings.
See individual commit messages for more details.
Fixes #8253