mtl/ofi: Do not fail if error CQ is empty #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multi-threaded scenarios, any thread that attempts to read a CQ when there's a pending error CQ entry gets an -FI_EAVAIL. Without any serialization here (which is okay, since libfabric will protect access to critical CQ objects), all threads proceed to read from the error CQ, but only one thread fetches the entry while others get -FI_EAGAIN indicating an empty queue, which is not erroneous. Signed-off-by: Raghu Raja <craghun@amazon.com>
bwbarrett
approved these changes
Oct 21, 2020
|
@rajachan could you cherry-pick this to the 4.0.x branch as well? thanks. |
|
@hppritcha done #8125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi-threaded scenarios, any thread that attempts to read a CQ
when there's a pending error CQ entry gets an -FI_EAVAIL. Without
any serialization here (which is okay, since libfabric will protect
access to critical CQ objects), all threads proceed to read from the
error CQ, but only one thread fetches the entry while others get
-FI_EAGAIN indicating an empty queue, which is not erroneous.
Signed-off-by: Raghu Raja craghun@amazon.com