Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtl/ofi: Do not fail if error CQ is empty #8113

Merged
merged 1 commit into from
Oct 21, 2020
Merged

mtl/ofi: Do not fail if error CQ is empty #8113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ompi/mca/mtl/ofi/mtl_ofi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,17 @@ ompi_mtl_ofi_context_progress(int ctxt_id)
&error,
0);
if (0 > ret) {
/*
* In multi-threaded scenarios, any thread that attempts to read
* a CQ when there's a pending error CQ entry gets an
* -FI_EAVAIL. Without any serialization here (which is okay,
* since libfabric will protect access to critical CQ objects),
* all threads proceed to read from the error CQ, but only one
* thread fetches the entry while others get -FI_EAGAIN
* indicating an empty queue, which is not erroneous.
*/
if (ret == -FI_EAGAIN)
return count;
opal_output(0, "%s:%d: Error returned from fi_cq_readerr: %s(%zd).\n"
"*** The Open MPI OFI MTL is aborting the MPI job (via exit(3)).\n",
__FILE__, __LINE__, fi_strerror(-ret), ret);
Expand Down