OPAL: fix string buffer allocation for large env variables #8144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
Oct 27, 2020
bosilca
reviewed
Oct 27, 2020
This was referenced Oct 30, 2020
jsquyres
reviewed
Oct 30, 2020
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
devreal
force-pushed
the
fix_opal_add_to_env_str_alloc
branch
from
ad5a432 to
320a9a1
Compare
jsquyres
approved these changes
Oct 30, 2020
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Oct 30, 2020
Track open-mpi/ompi#8144 Signed-off-by: Ralph Castain <rhc@pmix.org>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Oct 30, 2020
Track open-mpi/ompi#8144 Also fix minor example issue Signed-off-by: Ralph Castain <rhc@pmix.org>
This was referenced Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OPAL's keyval parser in
add_to_env_str, for the first variable a buffer of size 1024 was allocated, regardless of the space needed. For any additional variables, the size might have been doubled at best, even if more space was required. This PR makes sure the allocated buffer is sufficiently large to store the value.See #8117
Note: the issue described in #8117 does not seem to occur on
master. I will backport this to 4.0.x (where it occurs) and 4.1.x (not tested yet) but the same code exists in PMIX and PRRTE so it should be picked up there as well.Signed-off-by: Joseph Schuchart schuchart@icl.utk.edu