OPAL: fix string buffer allocation for large env variables [4.0.x] #8156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This is not yet merged on master. Only merge this PR after #8144 is merged. |
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 320a9a1)
devreal
force-pushed
the
fix_opal_add_to_env_str_alloc_v4.0.x
branch
from
16260a1 to
e39d1f3
Compare
|
Updated with latest change from #8144 |
jsquyres
approved these changes
Oct 30, 2020
Coverity complained about uninitialized variables; ensure that they are initialized to 0 in all cases. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit eac0ab5)
Slightly improve comments and update some whitespace. No code or logic changes. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 8ed1d28)
|
Added commits from #8163 to this PR (i.e., cherry picked the Coverity fixes that were found after we merged to master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OPAL's keyval parser in
add_to_env_str, for the first variable a buffer of size 1024 was allocated, regardless of the space needed. For any additional variables, the size might have been doubled at best, even if more space was required. This PR makes sure the allocated buffer is sufficiently large to store the value.Cherry-pick of #8144 to v4.0.x release branch.
Fixes #8117
Signed-off-by: Joseph Schuchart schuchart@icl.utk.edu
Also included cherry pick of #8163 (some coverity fixes that we found after we merged to master)