Fix some SM OSC component initialization issues #9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bool interpretation, which had a bug that made it impossible to interpret the strings "false" or "no" properly. Fix issues uncovered with handling overflow and underflow of the int type when writing the test. Add a test for the opal_cstring interface. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Fix WIN_SHARED initialization and error reporting by pushing the actual generation of MPI_ERR_RMA_SHARED errors until component selection (from component query). Components that don't do FLAVOR_SHARED should just return -1 for query. SM, since it should always work for FLAVOR_SHARED, will return a priority for component_query() for any FLAVOR_SHARED window, then will generate the MPI_ERR_RMA_SHARED error during component_select. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
For some reason, the SM OSC component was one of the few components which did not have an MCA parameter to set priority. This patch fixes that. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
devreal
approved these changes
Feb 8, 2022
| @@ -33,7 +33,7 @@ static void opal_cstring_ctor(opal_cstring_t *obj) | |||
| { | |||
| *(size_t *) &(obj->length) = 0; | |||
| /* make sure the string is null-terminated */ | |||
| ((char *) obj->string)[0] = '\n'; | |||
| ((char *) obj->string)[0] = '\0'; | |||
There was a problem hiding this comment.
Mea culpa, thanks for catching that :(
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix three mostly unrelated issues that rendered the SM OSC component less than useful: