Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some SM OSC component initialization issues #9991

Merged
merged 3 commits into from
Feb 8, 2022

Commits on Feb 8, 2022

  1. class/cstring: Fix handling of corner cases

    Fix the bool interpretation, which had a bug that made it impossible
    to interpret the strings "false" or "no" properly.
    
    Fix issues uncovered with handling overflow and underflow of the int
    type when writing the test.
    
    Add a test for the opal_cstring interface.
    
    Signed-off-by: Brian Barrett <bbarrett@amazon.com>
    bwbarrett committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    4f42204 View commit details
    Browse the repository at this point in the history
  2. osc: Fix WIN_SHARED initialization

    Fix WIN_SHARED initialization and error reporting by pushing the actual
    generation of MPI_ERR_RMA_SHARED errors until component selection (from
    component query).  Components that don't do FLAVOR_SHARED should just
    return -1 for query.  SM, since it should always work for FLAVOR_SHARED,
    will return a priority for component_query() for any FLAVOR_SHARED
    window, then will generate the MPI_ERR_RMA_SHARED error during
    component_select.
    
    Signed-off-by: Brian Barrett <bbarrett@amazon.com>
    bwbarrett committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    efec44c View commit details
    Browse the repository at this point in the history
  3. osc/sm: Add MCA parameter to set priority

    For some reason, the SM OSC component was one of the few components
    which did not have an MCA parameter to set priority.  This patch
    fixes that.
    
    Signed-off-by: Brian Barrett <bbarrett@amazon.com>
    bwbarrett committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    1112744 View commit details
    Browse the repository at this point in the history