Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Remote Write Exporter (3/7) #11

Closed
wants to merge 1 commit into from

Conversation

shovnik
Copy link

@shovnik shovnik commented Nov 20, 2020

Description

This is PR 3/7 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/7

  • Adds class skeleton
  • Adds all function signatures

Part 2/7

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

👉 Part 3/7

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

Part 4/7

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

Part 5/7

  • Add support for optional request parameters (timeout, proxy)
  • Add support for tls config

Part 6/7

  • Add integration tests using sample app and instance of Cortex

Part 7/7

  • Add README, Design Doc and other necessary documentation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added class TestValidation in test_prometheus_remote_write_exporter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated (change logs will be updated when PR 7/7 is merged and the RW exporter is complete)
  • Unit tests have been added
  • Documentation has been updated
    cc- @AzfaarQureshi , @alolita

@shovnik shovnik self-assigned this Nov 20, 2020
@shovnik shovnik force-pushed the 1-prometheus-remote-write branch from a32026b to 6ab3822 Compare November 20, 2020 01:04
@shovnik shovnik force-pushed the 2-prometheus-remote-write branch from 6848cfd to 3f1e246 Compare November 20, 2020 01:09
@AzfaarQureshi AzfaarQureshi changed the title Add Conversion to TimeSeries Logic to Exporter PR 3/7 Add Conversion to TimeSeries Logic to Exporter (3/7) Nov 20, 2020
@AzfaarQureshi AzfaarQureshi changed the title Add Conversion to TimeSeries Logic to Exporter (3/7) Prometheus Remote Write Exporter (3/7) Nov 20, 2020

# TODO: Implement convert from quantile once supported by SDK for Prometheus Summaries
def convert_from_quantile(
self, summary_record: ExportRecord

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For things you haven't written yet might want to throw NotImplementedError

@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch 3 times, most recently from a2b265b to e56a4da Compare November 20, 2020 18:27
@shovnik shovnik force-pushed the 1-prometheus-remote-write branch from e56a4da to 18a25f4 Compare November 20, 2020 18:34
@shovnik shovnik force-pushed the 2-prometheus-remote-write branch from 3f1e246 to d550a5f Compare November 20, 2020 18:41
@shovnik shovnik force-pushed the 2-prometheus-remote-write branch from d550a5f to a6732c4 Compare November 20, 2020 18:46
@shovnik shovnik requested a review from alolita November 20, 2020 19:18
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shovnik shovnik closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants