Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Remote Write Exporter (4/7) #12

Closed

Conversation

AzfaarQureshi
Copy link

@AzfaarQureshi AzfaarQureshi commented Nov 20, 2020

Description

This is PR 4/7 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/7

  • Adds class skeleton
  • Adds all function signatures

Part 2/7

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

Part 3/7

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

👉 Part 4/7

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

Part 5/7

  • Add support for optional request parameters (timeout, proxy)
  • Add support for tls config

Part 6/7

  • Add integration tests using sample app and instance of Cortex

Part 7/7

  • Add README, Design Doc and other necessary documentation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added class TestValidation in test_prometheus_remote_write_exporter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated (change logs will be updated when PR 7/7 is merged and the RW exporter is complete)
  • Unit tests have been added
  • Documentation has been updated
    cc- @shovnik, @alolita

@AzfaarQureshi AzfaarQureshi changed the title Adding export methods Prometheus Remote Write Exporter (4/7) Nov 20, 2020
@shovnik shovnik force-pushed the 2-prometheus-remote-write branch 2 times, most recently from d550a5f to a6732c4 Compare November 20, 2020 18:46
@AzfaarQureshi AzfaarQureshi force-pushed the 3-prometheus-remote-write branch 2 times, most recently from e89b5cf to 6baa144 Compare November 20, 2020 18:58
@shovnik shovnik requested a review from alolita November 20, 2020 19:15
@AzfaarQureshi AzfaarQureshi force-pushed the 3-prometheus-remote-write branch 6 times, most recently from b3c8e81 to dbcb381 Compare November 23, 2020 22:01
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shovnik shovnik force-pushed the 2-prometheus-remote-write branch from a6732c4 to ed1f7d8 Compare November 24, 2020 20:18
@shovnik shovnik force-pushed the 3-prometheus-remote-write branch 4 times, most recently from ad98cc1 to 09fe5a2 Compare November 24, 2020 21:40
@shovnik shovnik force-pushed the 2-prometheus-remote-write branch from ed1f7d8 to e9e348d Compare November 24, 2020 21:50
@shovnik shovnik force-pushed the 3-prometheus-remote-write branch from 09fe5a2 to ac5f46f Compare November 24, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants