-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extension APIService definition updates #36
Conversation
cb4bd77
to
d629957
Compare
cc @mmirecki @adrianludwin @ritazh for visibility/review |
Thanks for the PR! Code LGTM. If you are willing to add the tests, it would definitely be helpful. |
/lgtm |
Adding tests for the other webhook types in #37, will rebase onto that once merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
#37 merged |
c7dc1e2
to
6fdd60c
Compare
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
6fdd60c
to
6b04f6e
Compare
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
f6c5cb1
to
ce78882
Compare
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 53.35% 53.64% +0.29%
==========================================
Files 1 1
Lines 373 384 +11
==========================================
+ Hits 199 206 +7
- Misses 115 117 +2
- Partials 59 61 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Rebased and resolved conflicts. Tests require version bumps to latest (k8s libs -> 0.23, controller-runtime -> 0.11, go -> 1.17) otherwise it gets stuck in version dependency errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adammw! |
This might causes issues with GK when we need to vendor if it requires controller-runtime 0.11. |
Add support for extension APIService definition updates via the cert-controller library.
The APIService definition points to a service and caBundle like the existing webhook types, and extends the kubernetes API server using the aggregation layer to provide access to alternate apiGroups via that server.
There were no tests for other types of
WebhookInfo
apart from theValidating
type - however I can work on adding some if required.