Add tests for other webhook types #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammw
force-pushed
the
adammw/mutating-test
branch
from
c426825 to
efa91a3
Compare
|
Thanks for writing the tests! It looks like the gomofules need to be updated. |
adammw
force-pushed
the
adammw/mutating-test
branch
from
efa91a3 to
64c62c9
Compare
|
updated |
|
It looks like there are merge conflicts on the go.mod file? |
sozercan
reviewed
Jan 20, 2022
pkg/rotator/rotator_test.go
Outdated
| @@ -9,7 +9,10 @@ import ( | |||
| "github.com/onsi/gomega" | |||
| admissionv1 "k8s.io/api/admissionregistration/v1" | |||
| corev1 "k8s.io/api/core/v1" | |||
| apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" | |||
There was a problem hiding this comment.
since v1beta1 is removed in k8s v1.22, should we use v1?
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
adammw
force-pushed
the
adammw/mutating-test
branch
from
64c62c9 to
78e920c
Compare
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
adammw
force-pushed
the
adammw/mutating-test
branch
from
78e920c to
d3e7cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test-table-driven-tests for TestReconcileWebhook providing a resource of each type.