-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mutation deploy yaml to v3.5.0-rc.1 #1342
update mutation deploy yaml to v3.5.0-rc.1 #1342
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
435a929
to
6803516
Compare
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
- Coverage 48.52% 48.23% -0.29%
==========================================
Files 68 68
Lines 4913 4913
==========================================
- Hits 2384 2370 -14
- Misses 2179 2187 +8
- Partials 350 356 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #1360 to address the other 2 issues. |
@@ -1148,7 +1148,7 @@ spec: | |||
valueFrom: | |||
fieldRef: | |||
fieldPath: metadata.name | |||
image: openpolicyagent/gatekeeper:v3.4.0 | |||
image: openpolicyagent/gatekeeper:v3.5.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutatingwebhookconfig is missing the following:
admissionReviewVersions:
- v1
- v1beta1
matchPolicy: Exact
514daec
to
c6efb51
Compare
This was missing a few things. Still LGTY @maxsmythe @ritazh? |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
c6efb51
to
0773694
Compare
Yep, though we definitely need to automate this. |
…agent#1342-upstream-release-3.5
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: