Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mutation deploy yaml to v3.5.0-rc.1 #1342

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jun 4, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the deploy-mutation-35rc1 branch from 435a929 to 6803516 Compare June 4, 2021 23:20
@codecov-commenter
Copy link

Codecov Report

Merging #1342 (435a929) into master (d00e886) will decrease coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 435a929 differs from pull request most recent head 6803516. Consider uploading reports for the commit 6803516 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   48.52%   48.23%   -0.29%     
==========================================
  Files          68       68              
  Lines        4913     4913              
==========================================
- Hits         2384     2370      -14     
- Misses       2179     2187       +8     
- Partials      350      356       +6     
Flag Coverage Δ
unittests 48.23% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 54.04% <0.00%> (-3.24%) ⬇️
pkg/controller/assign/assign_controller.go 48.33% <0.00%> (-1.67%) ⬇️
pkg/readiness/object_tracker.go 82.60% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00e886...6803516. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I wonder if we should take the opportunity to set side effects and maybe the ignore labelselector?

Ignore bug: #1341

Dryrun bug: #1353

@ritazh
Copy link
Member

ritazh commented Jun 12, 2021

I opened #1360 to address the other 2 issues.

@@ -1148,7 +1148,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.name
image: openpolicyagent/gatekeeper:v3.4.0
image: openpolicyagent/gatekeeper:v3.5.0-rc.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutatingwebhookconfig is missing the following:

  admissionReviewVersions:
  - v1
  - v1beta1
  matchPolicy: Exact

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the deploy-mutation-35rc1 branch 3 times, most recently from 514daec to c6efb51 Compare June 15, 2021 18:05
@sozercan
Copy link
Member Author

This was missing a few things. Still LGTY @maxsmythe @ritazh?

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the deploy-mutation-35rc1 branch from c6efb51 to 0773694 Compare June 15, 2021 18:13
@maxsmythe
Copy link
Contributor

Yep, though we definitely need to automate this.

@sozercan sozercan merged commit b3c706a into open-policy-agent:master Jun 16, 2021
@sozercan sozercan deleted the deploy-mutation-35rc1 branch June 16, 2021 05:21
@ritazh ritazh added this to the v3.5.0 milestone Jun 17, 2021
sozercan added a commit to sozercan/gatekeeper that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants