Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default configs to mutatingwebhookconfig #1360

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jun 12, 2021

Signed-off-by: Rita Zhang rita.z.zhang@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1341, fixes #1353

Special notes for your reviewer:

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #1360 (b5e645a) into master (bf94eb3) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   49.69%   49.53%   -0.17%     
==========================================
  Files          68       68              
  Lines        4926     4926              
==========================================
- Hits         2448     2440       -8     
- Misses       2134     2141       +7     
- Partials      344      345       +1     
Flag Coverage Δ
unittests 49.53% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/object_tracker.go 80.97% <0.00%> (-1.64%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 57.28% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf94eb3...b5e645a. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit d66fc95 into open-policy-agent:master Jun 15, 2021
@ritazh ritazh deleted the fix-mutatingwebhookconfig branch June 15, 2021 05:06
@ritazh ritazh added this to the v3.5.0 milestone Jun 17, 2021
sozercan added a commit to sozercan/gatekeeper that referenced this pull request Jun 17, 2021
sozercan added a commit that referenced this pull request Jun 17, 2021
…1372)

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutating Webhook Configurations side effect configuration chart mutating webhook ignore namespace
4 participants