fix: name matcher to match generate names as well #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxsmythe @ritazh @sozercan Please take a look when you get a chance |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2841 +/- ##
==========================================
+ Coverage 53.49% 53.52% +0.02%
==========================================
Files 133 133
Lines 11536 11545 +9
==========================================
+ Hits 6171 6179 +8
- Misses 4887 4888 +1
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
maxsmythe
reviewed
Jun 20, 2023
|
@JaydipGabani looks like there are some conflicts due to #2853 being merged, can you ptal |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
|
@sozercan @maxsmythe PTAL, resolved the merge conflict and nit. |
This was referenced Nov 22, 2023
dhaiducek
pushed a commit
to dhaiducek/gatekeeper
that referenced
this pull request
Jan 15, 2024
dhaiducek
pushed a commit
to dhaiducek/gatekeeper
that referenced
this pull request
Jan 15, 2024
…2841) ref: https://issues.redhat.com/browse/ACM-9430 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
openshift-merge-bot bot
pushed a commit
to stolostron/gatekeeper
that referenced
this pull request
Jan 16, 2024
…2841) ref: https://issues.redhat.com/browse/ACM-9430 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
namesMatchfails to return true with the objects that havegenerateNameset instead ofname.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #2832
Special notes for your reviewer: