Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master with 3.14 #189

Closed
wants to merge 256 commits into from
Closed

Replace master with 3.14 #189

wants to merge 256 commits into from

Conversation

yiraeChristineKim
Copy link

No description provided.

davis-haba and others added 30 commits November 24, 2023 16:17
* Implement AssignImage mutator
Signed-off-by: davis-haba <davishaba@google.com>

* fix tests
Signed-off-by: davis-haba <davishaba@google.com>

* fix controller gen setup
Signed-off-by: davis-haba <davishaba@google.com>

* fix helm manifest generation
Signed-off-by: davis-haba <davishaba@google.com>

* WIP assignimage byPod status
Signed-off-by: davis-haba <davishaba@google.com>

* mutator pod status working for assignimage
Signed-off-by: davis-haba <davishaba@google.com>

* e2e test assignimage mutator deleted
Signed-off-by: davis-haba <davishaba@google.com>

* old kubectl run
Signed-off-by: davis-haba <davishaba@google.com>

* address comments. domain must have '.' unless localhost
Signed-off-by: davis-haba <davishaba@google.com>

* appease linter
Signed-off-by: davis-haba <davishaba@google.com>

* fix gator tests
Signed-off-by: davis-haba <davishaba@google.com>

* add test domain ending in colon still converges
Signed-off-by: davis-haba <davishaba@google.com>

* docs for assignimage
Signed-off-by: davis-haba <davishaba@google.com>

* remove newline
Signed-off-by: davis-haba <davishaba@google.com>

* address comments
Signed-off-by: davis-haba <davishaba@google.com>

* appease linter
Signed-off-by: davis-haba <davishaba@google.com>

* cleanup dead code branch
Signed-off-by: davis-haba <davishaba@google.com>

* validateDomain to use splitDomain
Signed-off-by: davis-haba <davishaba@google.com>

* future-proof validateImageParts. Add custom error types.
Signed-off-by: davis-haba <davishaba@google.com>

* fix readiness tracker test
Signed-off-by: davis-haba <davishaba@google.com>

* make manifests
Signed-off-by: davis-haba <davishaba@google.com>

* validate that splitting a valid tag never returns a path
Signed-off-by: davis-haba <davishaba@google.com>

* degenerate cases for unit tests. do not expose regex on image component error.
Signed-off-by: davis-haba <davishaba@google.com>

* test missing image field. update error copy.
Signed-off-by: davis-haba <davishaba@google.com>

* tag error copy
Signed-off-by: davis-haba <davishaba@google.com>

* Update pkg/expansion/system_test.go

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

* Update pkg/mutation/mutators/assignimage/assignimage_mutator.go

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>

* errors.As instead of type casting in unit tests
Signed-off-by: davis-haba <davishaba@google.com>

* fix error type checking
Signed-off-by: davis-haba <davishaba@google.com>

Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
…y-agent#2530)

* Upgrade to k8s v0.26.1 and controller-runtime fork

Signed-off-by: Max Smythe <smythe@google.com>

* Re-add stop channel to informer map entry

Signed-off-by: Max Smythe <smythe@google.com>

* Update linter version

Signed-off-by: Max Smythe <smythe@google.com>

* Fix lint errors

Signed-off-by: Max Smythe <smythe@google.com>

* Fix broken tests

Signed-off-by: Max Smythe <smythe@google.com>

* Fix function docstring

Signed-off-by: Max Smythe <smythe@google.com>

* Fix gofumpt violation

Signed-off-by: Max Smythe <smythe@google.com>

Signed-off-by: Max Smythe <smythe@google.com>
…-agent#2536)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…cy-agent#2535)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…ent#2543)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2547)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2546)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add --operation=mutation-controller flag
Signed-off-by: davis-haba <davishaba@google.com>

* operations in sorted order
Signed-off-by: davis-haba <davishaba@google.com>

* update mutation-controller op docs to indicate audit may also need the
flag
Signed-off-by: davis-haba <davishaba@google.com>

---------

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…cy-agent#2545)

Introduce gci to unify the order of package import

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
…ted (since v1.49.0) (open-policy-agent#2550)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…ent#2564)

removed unused kustomize step

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…nt#2581)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2566)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2565)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2567)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2568)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Max Smythe <smythe@google.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Max Smythe <smythe@google.com>
acpana and others added 16 commits November 24, 2023 16:19
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
…#3060)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#3070)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olicy-agent#3069)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Co-authored-by: JaydipGabani <JaydipGabani@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Co-authored-by: sozercan <sozercan@users.noreply.github.com>
…ck for 3.14 (open-policy-agent#3141)

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: sozercan <sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Co-authored-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: Yi Rae Kim <yikim@redhat.com>
ref: https://issues.redhat.com/browse/ACM-6233

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Co-authored-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Yi Rae Kim <yikim@redhat.com>
Signed-off-by: Yi Rae Kim <yikim@redhat.com>
Copy link

openshift-ci bot commented Nov 24, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 24, 2023

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the stolostron org. You can then trigger verification by writing /verify-owners in a comment.

  • JoelSpeed
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • sbueringer
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • testing-integration-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • controller-runtime-admins
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/OWNERS
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-reviewers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/OWNERS
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-maintainers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • schrej
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS

@dhaiducek
Copy link

I'm assuming this is bringing the master branch up-to-date? I mentioned keeping the branches in sync to @mprahl the other day. We'll have to figure out a process for this. @mprahl was of the opinion that this master and upstream should be 100% in sync. If we do that, we can set up a periodic fast-forward from upstream to here and then somehow calculate and automate which changes we need cherry-picked (like TLS, CGO, etc) each time we cut our own release.

@yiraeChristineKim
Copy link
Author

@dhaiducek Thanks Dale!!

@mprahl
Copy link

mprahl commented Nov 27, 2023

@yiraeChristineKim , could you please describe the purpose of this PR a bit?

@yiraeChristineKim
Copy link
Author

@mprahl sync master with v3.14.0 I guess this is a wrong way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.