Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pkg imported more than once #2851

Merged
merged 1 commit into from
Jul 5, 2023
Merged

chore: pkg imported more than once #2851

merged 1 commit into from
Jul 5, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jun 28, 2023

What this PR does / why we need it:
pkg is being imported more than once
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.08 🎉

Comparison is base (6aad7b6) 53.50% compared to head (e876724) 53.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
+ Coverage   53.50%   53.58%   +0.08%     
==========================================
  Files         133      133              
  Lines       11536    11536              
==========================================
+ Hits         6172     6182      +10     
+ Misses       4887     4879       -8     
+ Partials      477      475       -2     
Flag Coverage Δ
unittests 53.58% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/expansion/expansion_controller.go 52.29% <0.00%> (ø)
pkg/instrumentation/types.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acpana acpana requested review from a team, ritazh, sozercan and maxsmythe June 28, 2023 19:11
Copy link
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR and catching this 💯

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!

@sozercan sozercan merged commit d8f2bbc into open-policy-agent:master Jul 5, 2023
@testwill testwill deleted the pkg-import branch July 6, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants