Add secret key object to XMSS #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashman-p
reviewed
Aug 18, 2023
| @@ -182,7 +182,7 @@ OQS_STATUS sig_stfl_kat(const char *method_name, const char *katfile) { | |||
| goto err; | |||
| } | |||
|
|
|||
| if (!ReadHex(fp_rsp, secret_key, sig->length_secret_key, "sk = ")) { | |||
| if (!ReadHex(fp_rsp, secret_key->secret_key_data, sig->length_secret_key, "sk = ")) { | |||
There was a problem hiding this comment.
OK for now but, we eventually will want to the serialize_key/deserialize_key to get and set the private key data.
secret_key->secret_key_data,
if (secret_key->serialize_key) {
sk_buff =secret_key->serialize_key(secret_key);
....
}
ashman-p
approved these changes
Aug 18, 2023
dstebila
force-pushed
the
stateful-sigs
branch
from
1aa5ed2 to
d759b80
Compare
dstebila
force-pushed
the
xmss_secret_key_object
branch
from
ea1041b to
ec19e17
Compare
dstebila
approved these changes
Aug 18, 2023
SWilson4
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
SWilson4
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
cothan
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
SWilson4
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
SWilson4
pushed a commit
that referenced
this pull request
May 14, 2024
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
cothan
added a commit
that referenced
this pull request
May 30, 2024
commit 244288f Add XMSS parameter xmss_sha256_h10 (#1482) commit a7e26d9 Add 12 XMSS and 16 XMSSMT parameters. (#1489) commit 4694fc3 Add secret key object to XMSS (#1530) commit 99067be Add XMSS Serialize/Deserialize (#1542) commit 2dbfc40 Update XMSS secret key object APIs, sync with LMS (#1588) commit 47740ad Enforce idx from unsigned int to uint32_t. (#1611) commit 9610576 Fix windows-x86 and arm compiling error. (#1634) commit bb658b7 Address stateful-sigs comments in #1650 (#1656) commit 7db8ddf Update `sig_stfl.h` document for #1650 (#1655) commit c3e5750 Add Apache 2.0 and MIT License to XMSS (#1662) commit e1f02b2 Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MIT) AND CC0-1.0` (#1697) commit 17c12c3 Add return status for XMSS lock/unlock functions. (#1712) commit 1941636 Add return check for lock/unlock function (#1727) commit b45415c Use `abort()` instead of exit to get the trace log. (#1728) commit ba63672 Reduce number of `malloc/free` call in `XMSS/external` (#1724) Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constwhen signing. Because the private key is updated.kat_sig_stfl.cto allocate memory and free secret object using the provided function in secret key object.test_sig_stfl.cto allocate memory and free secret object using the provided function in secret key object.