Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows-x86 and arm compiling error. #1634

Merged
merged 22 commits into from
Jan 2, 2024
Merged

Fix windows-x86 and arm compiling error. #1634

merged 22 commits into from
Jan 2, 2024

Conversation

ducnguyen-sb
Copy link
Contributor

This PR improved XMSS compiling error in Windows-x86 and Windows ARM.

  • Use malloc instead of dynamic stack array.
  • Fixed astyle
  • Fixed a typo in sha2_armv8.
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ducnguyen-sb ducnguyen-sb marked this pull request as draft December 19, 2023 15:24
@ducnguyen-sb
Copy link
Contributor Author

@ashman-p Can you update LMS to read public/private key from KAT file? I have timeout generating the key H15_w8 and H20_w1, I didn't test further.

@ashman-p
Copy link
Contributor

@ashman-p Can you update LMS to read public/private key from KAT file? I have timeout generating the key H15_w8 and H20_w1, I didn't test further.

Yes, did you want me to do it on this branch?

@ducnguyen-sb
Copy link
Contributor Author

@ashman-p , yes, feel free.

@ducnguyen-sb
Copy link
Contributor Author

Okay only the README is left.

@baentsch
Copy link
Member

Okay only the README is left.

This is what I mentioned in the call on Tuesday: The generator removes manually changed text: This PR adds apparently manually curated algorithm lists into the code generation template brackets: Either you keep maintaining this manually, but then have to move your changes outside the "OQS_TEMPLATE_FRAGMENT_...START ...END" brackets or add logic for adding the new algorithms into the copy_from_upstream logic (if you take LMS/XMSS from some upstream location) to make this CI test pass.

@ducnguyen-sb ducnguyen-sb marked this pull request as ready for review January 1, 2024 17:46
@ducnguyen-sb
Copy link
Contributor Author

Now, all the tests have passed.
To fix the copy_from_upstream error, I moved the OQS_TEMPLATE_FRAGMENT_...START ...END outside of XMSS/LMS location.

I know that I won't add any additional parameters for XMSS.
For LMS, if you've finalized all the parameters you need @ashman-p , I can merge this PR now.
Otherwise, next time you add a parameter, you have to edit the README.md manually to update the additional LMS parameters.

What do you think?

@ducnguyen-sb ducnguyen-sb merged commit e067a23 into stateful-sigs Jan 2, 2024
52 checks passed
@ducnguyen-sb ducnguyen-sb deleted the fix_windows_x86_xmss branch January 2, 2024 21:17
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ducnguyen-sb @ashman-p @SWilson4
Fix windows-x86 and arm compiling error. (#1634)
b09ffd2 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ducnguyen-sb @ashman-p @cothan
Fix windows-x86 and arm compiling error. (#1634)
1249ce2 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @ashman-p @SWilson4
Fix windows-x86 and arm compiling error. (#1634)
86b39cf 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @ashman-p @SWilson4
Fix windows-x86 and arm compiling error. (#1634)
eaf381b 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @ashman-p @SWilson4
Fix windows-x86 and arm compiling error. (#1634)
4724d4c 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ducnguyen-sb @ashman-p @SWilson4
Fix windows-x86 and arm compiling error. (#1634)
9610576 
* Fix windows-x86 and arm compiling error.

---------

Co-authored-by: Norman Ashley <nashley@cisco.com>
cothan added a commit that referenced this pull request May 30, 2024
@cothan
I, Duc Nguyen, retroactively sign off on these commits:
d37f20d 
commit 244288f Add XMSS parameter xmss_sha256_h10 (#1482)
commit a7e26d9 Add 12 XMSS and 16 XMSSMT parameters. (#1489)
commit 4694fc3 Add secret key object to XMSS (#1530)
commit 99067be Add XMSS Serialize/Deserialize  (#1542)
commit 2dbfc40 Update XMSS secret key object APIs, sync with LMS  (#1588)
commit 47740ad Enforce idx from unsigned int to uint32_t. (#1611)
commit 9610576 Fix windows-x86 and arm compiling error. (#1634)
commit bb658b7 Address  stateful-sigs comments in #1650 (#1656)
commit 7db8ddf Update `sig_stfl.h` document for #1650 (#1655)
commit c3e5750 Add Apache 2.0 and MIT License to XMSS (#1662)
commit e1f02b2 Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MIT) AND CC0-1.0` (#1697)
commit 17c12c3 Add return status for XMSS lock/unlock functions. (#1712)
commit 1941636 Add return check for lock/unlock function (#1727)
commit b45415c Use `abort()` instead of exit to get the trace log. (#1728)
commit ba63672 Reduce number of `malloc/free` call in `XMSS/external` (#1724)

Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashman-p ashman-p ashman-p approved these changes

@dstebila dstebila Awaiting requested review from dstebila

@baentsch baentsch Awaiting requested review from baentsch

@bhess bhess Awaiting requested review from bhess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ducnguyen-sb @ashman-p @baentsch