Revert the previous change in 250681196f #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make style check fail when astyle fails.
|
Looking at the build output more closely it also seems like the error "find: unknown predicate `-E'" has been happening since e937a6a. |
Not necessary for the regex and not compatible with the linux(GNU) version of find.
|
Will merge this later today if there are no objections. |
Closed
tlepoint
reviewed
Nov 17, 2016
| elif [ ${STATUS[0]} != 0 ]; then | ||
| tput setaf 1; | ||
| echo "prettyprint failed."; | ||
| tput sgr 0; | ||
| exit 1; | ||
| else | ||
| tput setaf 2; | ||
| echo "Code adheres to the project standards."; |
There was a problem hiding this comment.
Maybe we should add Code adheres to the project standards (prettyprint) here.
tlepoint
reviewed
Nov 17, 2016
| @@ -4,10 +4,12 @@ if [[ $(nm -g liboqs.a | grep ' T ' | grep -E -v -i ' T [_]?OQS') ]]; | |||
| then | |||
| tput setaf 1; | |||
| echo "Code contains the following non-namespaced global symbols; see https://github.com/open-quantum-safe/liboqs/wiki/Coding-conventions for function naming conventions."; | |||
| tput sgr 0 | |||
| nm -g liboqs.a | grep ' T ' | grep -E -v -i ' T [_]?OQS' | |||
| exit 1; | |||
| else | |||
| tput setaf 2; | |||
| echo "Code adheres to the project standards."; | |||
There was a problem hiding this comment.
Maybe we should add Code adheres to the project standards (global namespace) here.
|
Good idea, Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make style check fail when astyle fails.