Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astyle -> clang-format? #56

Closed
tlepoint opened this issue Nov 17, 2016 · 7 comments
Closed

astyle -> clang-format? #56

tlepoint opened this issue Nov 17, 2016 · 7 comments
Assignees
@tlepoint
Labels
refactor Reorganizing existing code

Comments

@tlepoint
Copy link
Contributor

In light of #53, I think it would be interesting to switch from astyle to clang-format. Clang-format is both a library and a stand-alone tool aiming at automatically reformatting C sources files, and continus to be developed while astyle has not been updated since December 2014.
@aparent
Copy link
Contributor

aparent commented Nov 17, 2016 •
edited
Loading

I agree. As a side benefit it is likely included by default on the build images so there would be no need to compile it for each build.

Not sure if it would be possible to keep the exact same formatting we have now though?

@dstebila
Copy link
Member

Okay, seems like a good idea. Can you come up with some command line options? Not a big deal if they don't reproduce the exact format, but I'd like to keep the main formatting principles.

@tlepoint
Copy link
Contributor Author

I'll do it this week! Is there a PR I should wait to be merged for before doing it (bitroting)? I'll also refactor slightly the travis files by creating a .travis directory.

@dstebila
Copy link
Member

I'd like to wait until #58 lands, which should be this Tuesday or Wednesday. The other big one is #47, but I'm not sure what the status of it is from a cryptographic perspective, so you can go ahead without it.

@dstebila dstebila added the refactor Reorganizing existing code label Nov 22, 2016
@dstebila
Copy link
Member

#58 has landed, so reformatting can go ahead.

@dstebila
Copy link
Member

I've tried to do this on a branch, but discovered that the version of Ubuntu in Travis (12.04 "precise") has a very old version of clang-format (3.4), which is missing a bunch of options to produce the desired format. Anyone know how to install a newer version of clang-format on an old Ubuntu? Otherwise we might have to stay with astyle.

@tlepoint
Copy link
Contributor Author

Sorry very hectic weeks recently, I didn't have time to look into that. I did it for fplll here.

@tlepoint tlepoint mentioned this issue Dec 28, 2016
Merged
@tlepoint tlepoint mentioned this issue Jan 7, 2017
Merged
dstebila pushed a commit that referenced this issue Jan 11, 2017
@tlepoint @dstebila
Clang format instead of astyle (#84)
c1568a1 
* replacing astyle by clang-format #56

* sh instead of bash

* sudo required now...

* prettyprint with clang-format

* debugging clang format

* order of include mattered in newhope

* trying again

* order in mcbits too

* includes in mcbits

* Trying again

* Change makefile for clangformat

* removing conditionals in makefile

* Order of include in mcbits:

* CLANGFORMAT for linux and macOS

* CLANGFORMAT for linux and macOS

* CLANGFORMAT for linux and macOS

* Warning of clang
@dstebila dstebila reopened this Jan 12, 2017
@kinkie kinkie mentioned this issue Apr 24, 2020
Closed
@cothan cothan mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlepoint tlepoint

Labels
refactor Reorganizing existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aparent @tlepoint @dstebila