Travis revisited (still with astyle) and nicer makefile output #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 28, 2016 14:08
|
@dstebila: I see that you did clang-format in 4f76861. Feel free to add it to this PR if you want, or to create a new one (I admit that the silent makefile can be a moot point). As said in #56, you can find how to install clang-format-3.9 in https://github.com/fplll/fplll/blob/master/.travis.yml for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modifications:
For the second point, it will be easier if eventually autotools is used (#20) as we can use
AM_SILENT_RULES. What is the plan wrt to that PR?I didn't feel confortable to change from astyle to clang-format (#56) because of the many possible options there. Should it be an unilateral choice, or should we discuss those?