Integrates MSR's RLWE Latticecrypto library into OQS. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/kex_rlwe_bcns15/kex_rlwe_bcns15.c src/rand_urandom_chacha20/rand_urandom_chacha20.c Merged winbuild with master.
Merged upstream oqs changes (fix windows build)
Merging with upstream.
Merge upstream/master.
Merge upstream.
…ict with other libs.
…reprocessor defs.
tlepoint
reviewed
Nov 21, 2016
| @@ -105,7 +106,7 @@ Over the next few months, we plan to be making the following updates: | |||
|
|
|||
| - Building on more systems, including building of assembly code / optimizations | |||
| - Inclusion of a McEliece-based key exchange method | |||
| - Inclusion of a supersingular isogeny Diffie–Hellman key exchange method | |||
| - Inclusion of a supersingular isogeny DiffieâHellman key exchange method | |||
tlepoint
reviewed
Nov 21, 2016
| @@ -127,7 +129,7 @@ The Open Quantum Safe project is lead by [Michele Mosca](http://faculty.iqc.uwat | |||
|
|
|||
| ### Contributors | |||
|
|
|||
| - Tancrède Lepoint (SRI) | |||
| - Tancrède Lepoint (SRI) | |||
tlepoint
reviewed
Nov 21, 2016
| /**************************************************************************************** | ||
| * LatticeCrypto: an efficient post-quantum Ring-Learning With Errors cryptography library | ||
| * | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. |
There was a problem hiding this comment.
What is the license of the implementation? (Maybe it should be added to the README too)
There was a problem hiding this comment.
The library is released under the MIT license (same as OQS). This is noted in the main Readme.md and in src/kex_rlwe_latticecrypto/LICENCE.txt.
tlepoint
reviewed
Nov 21, 2016
| @@ -26,6 +26,7 @@ liboqs currently contains: | |||
| - `rand_urandom_chacha20`: pseudorandom number generator seeded from /dev/urandom and expanded using the ChaCha20 stream cipher | |||
| - `kex_rlwe_bcns15`: key exchange from the ring learning with errors problem (Bos, Costello, Naehrig, Stebila, *IEEE Symposium on Security & Privacy 2015*, [https://eprint.iacr.org/2014/599](https://eprint.iacr.org/2014/599)) | |||
| - `kex_rlwe_newhope`: "NewHope": key exchange from the ring learning with errors problem (Alkim, Ducas, Pöppelmann, Schwabe, *USENIX Security 2016*, [https://eprint.iacr.org/2015/1092](https://eprint.iacr.org/2015/1092)) (using the reference C implementation of NewHope from [https://github.com/tpoeppelmann/newhope](https://github.com/tpoeppelmann/newhope)) | |||
| - `kex_rlwe_latticecrypto`: MSR implementation of Peikert's RLWE key exchange, based on the implementation of Alkim, Ducas, Pöppelmann, and Schwabe, [https://www.microsoft.com/en-us/research/project/lattice-cryptography-library/](https://www.microsoft.com/en-us/research/project/lattice-cryptography-library/) | |||
There was a problem hiding this comment.
Coding error here too. And on the line above.
tlepoint
reviewed
Nov 21, 2016
| * @param outputByteLen The number of output bytes desired. | ||
| * @pre One must have r+c=1600 and the rate a multiple of 8 bits in this implementation. | ||
| */ | ||
| void Keccak(unsigned int rate, unsigned int capacity, const unsigned char *input, unsigned long long int inputByteLen, unsigned char delimitedSuffix, unsigned char *output, unsigned long long int outputByteLen); |
There was a problem hiding this comment.
This will eventually be "incompatible" with #47 which factors out sha3/shake128. Depending on the timeline, you might have to rebase this PR.
Conflicts: Makefile Merged-in updated upstrea/master branch and fixed conflict in Makefile.
tlepoint
reviewed
Nov 21, 2016
| @@ -25,7 +25,8 @@ liboqs currently contains: | |||
|
|
|||
| - `rand_urandom_chacha20`: pseudorandom number generator seeded from /dev/urandom and expanded using the ChaCha20 stream cipher | |||
| - `kex_rlwe_bcns15`: key exchange from the ring learning with errors problem (Bos, Costello, Naehrig, Stebila, *IEEE Symposium on Security & Privacy 2015*, [https://eprint.iacr.org/2014/599](https://eprint.iacr.org/2014/599)) | |||
| - `kex_rlwe_newhope`: "NewHope": key exchange from the ring learning with errors problem (Alkim, Ducas, Pöppelmann, Schwabe, *USENIX Security 2016*, [https://eprint.iacr.org/2015/1092](https://eprint.iacr.org/2015/1092)) (using the reference C implementation of NewHope from [https://github.com/tpoeppelmann/newhope](https://github.com/tpoeppelmann/newhope)) | |||
| - `kex_rlwe_newhope`: "NewHope": key exchange from the ring learning with errors problem (Alkim, Ducas, P�ppelmann, Schwabe, *USENIX Security 2016*, [https://eprint.iacr.org/2015/1092](https://eprint.iacr.org/2015/1092)) (using the reference C implementation of NewHope from [https://github.com/tpoeppelmann/newhope](https://github.com/tpoeppelmann/newhope)) | |||
| - `kex_rlwe_latticecrypto`: MSR implementation of Peikert's RLWE key exchange, based on the implementation of Alkim, Ducas, Pöppelmann, and Schwabe, [https://www.microsoft.com/en-us/research/project/lattice-cryptography-library/](https://www.microsoft.com/en-us/research/project/lattice-cryptography-library/) | |||
There was a problem hiding this comment.
Still an encoding error here.
tlepoint
reviewed
Nov 21, 2016
|
|
||
| LatticeCrypto is a post-quantum secure cryptography library based on the Ring-Learning with Errors (R-LWE) | ||
| problem. The version 1.0 of the library implements the instantiation of Peikert's key exchange [1] due to | ||
| Alkim, Ducas, P�ppelmann and Schwabe [2], and incorporates novel techniques to provide higher performance. |
tlepoint
reviewed
Nov 21, 2016
|
|
||
| [1] C. Peikert, "Lattice cryptography for the internet", in Post-Quantum Cryptography - 6th International | ||
| Workshop (PQCrypto 2014), LNCS 8772, pp. 197-219. Springer, 2014. | ||
| [2] E. Alkim, L. Ducas, T. P�ppelmann and P. Schwabe, "Post-quantum key exchange - a new hope", IACR Cryp- |
Closed
We use UTF-8 for files that have accented characters in them.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates MSR's implementation of Peikert's RLWE key exchange, based on the newhope implementation and using new algorithms for the underlying Number Theoretic Transform (NTT). https://www.microsoft.com/en-us/research/project/lattice-cryptography-library/
The ASM/AVX2 mode, supported in the LatticeCrypto library, is currently not enabled in OQS. This will be done in a subsequent commit.