Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on dashboard map rendering when switching floors #532

Closed
3 tasks
youliangtan opened this issue Oct 22, 2021 · 2 comments · Fixed by #644
Closed
3 tasks

Issue on dashboard map rendering when switching floors #532

youliangtan opened this issue Oct 22, 2021 · 2 comments · Fixed by #644
Labels
bug Something isn't working

Comments

@youliangtan
Copy link
Member

youliangtan commented Oct 22, 2021

Bug report

This issue occurs when running a multilevel rmf world (e.g. open-rmf/rmf_demos#98). The first level of the hotel_world, level L1 looks fine.

Screenshot from 2021-10-21 15-26-42

However, when switching to L2 or L3, we can see the misalignment of the map as shown below. Even on L2, the map still shows building_maps_msgs elements (doors, waypoints, robots...) of L1.

Screenshot from 2021-10-21 15-27-18

On a side note, there's also some scaling issue with the lift/robots/doors when zooming in and out the canvas.

Issues

To recap, the issues are listed here:

  • Incorrect transformation of the floorplan png. Further offset/scaling can be applied to the floorplan png via the information provided in AffineImage
  • Scaling of the assets (lifts, doors, robots) on the map for different zoom levels. Assets should depict their actual scale. (if im not wrong on this)
  • Assets rendering when switching floor levels. Assets (also trajectories) from different floors should be filtered out from the map in accordance with the current floor level. This filtering can be done either on the client/server-side. If on the server-side, we might need to add a param level_name to the rest API. Similarly for socketio.
@youliangtan youliangtan added the bug Something isn't working label Oct 22, 2021
@aaronchongth
Copy link
Member

aaronchongth commented Oct 25, 2021

Per VC, @youliangtan, could you provide more information about this issue, how to recreate it, and the suggested implementations regarding the alignment of the lifts.

@youliangtan
Copy link
Member Author

Updated the description of the issue above, with further information mentioned under ##issues. I think this can be broken down into 3 major tasks. I dropped down a few suggestions, and feel free to correct me as I'm not too familiar with the inner working of rmf-web.
Also, I will update the rmf-launcher.js once the hotel world is merged into rmf_demos. Soon we will then use hotel world as a test subject for development. Hopefully, ensure rmf-web can fully support a multi-level world. Thanks. @vallq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants