-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-components/dashboard] upgrade react-leaflet and fix map overlays #553
Conversation
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
* resolve cherry pick Signed-off-by: ChawinTan <chawin15@gmail.com> * zooming for door panel Signed-off-by: ChawinTan <chawin15@gmail.com> * onclick lift cell Signed-off-by: ChawinTan <chawin15@gmail.com> * add zomming for remaining components Signed-off-by: ChawinTan <chawin15@gmail.com> * add hover and fix story and test errors Signed-off-by: ChawinTan <chawin15@gmail.com> * clean up Signed-off-by: ChawinTan <chawin15@gmail.com> * add hover color Signed-off-by: ChawinTan <chawin15@gmail.com> * fix panning animation Signed-off-by: ChawinTan <chawin15@gmail.com>
…re/infrastructure-tab Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
…re/infrastructure-tab Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
…ap-overlays Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 80.28% 79.73% -0.56%
==========================================
Files 255 253 -2
Lines 5367 5432 +65
Branches 602 611 +9
==========================================
+ Hits 4309 4331 +22
- Misses 871 905 +34
- Partials 187 196 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…rmf/rmf-web into fix/map-overlays Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Per VC, there were breaking changes in the newer release of This new ticket can be used to track that version update, #558. |
Signed-off-by: vallq <val@openrobotics.org>
…ap-overlays Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
…ap-overlays Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Signed-off-by: vallq <val@openrobotics.org>
Update
Fixes needed:
Trajectory Time Control
Label Markers
|
closing with #644 |
What's new
fixes #532
The initial version of react-leaflet used was no longer supported and the API broke, hence upgrading was necessary.
Upgraded to use react-leaflet
v3.1.0
The reason for not using the latest
v3.2.2
is because there is an existing incompatibility ofv3.2.0
and above with Webpack 4 which create-react-app uses as outlined here. I wasn't able to resolve the issues with the temporary solutions provided hence next best move is to usev3.1.0
Clicking on the different levels rendered will now show the corresponding icons
Self-checks
Others