Retry on dashboard e2e workflows #701

aaronchongth · 2023-03-31T07:41:36Z

What's new

Using nick-fields/retry@v2 for flaky dashboard-e2e workflow tests.

I have prototyped this new feature (if necessary) on Figma
I'm familiar with and follow this Typescript guideline
I added unit-tests for new components
I tried testing edge cases
I tested the behavior of the components that interact with the backend, with an e2e test

The proper fix should be resolving what is making the e2e tests flaky, keeping this as a draft for consideration while we continue down our roadmap.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth added 4 commits March 31, 2023 03:16

Retry on dashboard-e2e nightly

b0674e4

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Retry on general dashboard-e2e workflow

d326317

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Setting required timeout_minutes to 20, removing optional retry_on

49c833d

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Adding working-directory on step due to nick-fields/retry#89

d596d5d

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth force-pushed the aaron/retry-dashboard-e2e branch from fb18342 to d596d5d Compare April 3, 2023 03:41

aaronchongth marked this pull request as ready for review April 3, 2023 03:50

aaronchongth merged commit cbc20e1 into main May 1, 2023

aaronchongth deleted the aaron/retry-dashboard-e2e branch May 1, 2023 04:09