Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nav graph for fleet manager and update Office world #263

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

xiyuoh
Copy link
Member

@xiyuoh xiyuoh commented Oct 4, 2024

The current Fleet Manager node takes in two arguments: fleet config file and navigation graph file. The latter is not being used anywhere throughout the code. This PR removes this argument from the script and the fleet adapter launch file. This would also allow us to use the fleet manager node for fleets without navigation graphs, e.g. read-only fleets.

Additionally this PR also slightly modifies the current Office world. Currently there exists a path between waypoints patrol_A1 and patrol_B, but in Gazebo the path is blocked by chairs and MiR models. 73cd00f modifies the nav graph lanes such that the robots can go to patrol_B using an unblocked path. Some of the Drawer models along the bottom of the Office world were also removed/moved to make space for robot patrol.

Before:
office_world_before

After:
office_world_after

Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
@xiyuoh xiyuoh changed the title Remove nav graph for fleet manager Remove nav graph for fleet manager and update Office world Oct 4, 2024
Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes the cluttered office. I believe this was done for a demonstration where nav2 was trained in simulation and the map used in real life, luckily the office became less cluttered since then!

@xiyuoh xiyuoh merged commit b1636b0 into main Oct 15, 2024
3 checks passed
@xiyuoh xiyuoh deleted the xiyu/fm_fix branch October 15, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants