Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speed limit publishing to full control fleet adapter #132

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Oct 13, 2021

New feature implementation

Implemented feature

Requires open-rmf/rmf_internal_msgs#28 Add publishing of lane level speed limit to full_control adapter.

Implementation description

This PR parses the graph and publishes the speed_limit if one was found when reading the navgraph so the downstream simulated robots can respect it.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #132 (009bfd0) into main (46c2bb9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
  Coverage   21.56%   21.56%              
==========================================
  Files         422      633     +211     
  Lines       34310    51558   +17248     
  Branches    16248    24387    +8139     
==========================================
+ Hits         7398    11120    +3722     
- Misses      18986    28545    +9559     
- Partials     7926    11893    +3967     
Flag Coverage Δ
tests 21.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observer.hpp
...er/src/rmf_fleet_adapter/agv/RobotUpdateHandle.cpp
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.cpp
...os2/rmf_fleet_adapter/src/door_supervisor/Node.cpp
...raffic_ros2/src/rmf_traffic_ros2/blockade/Node.cpp
...s2/src/rmf_traffic_ros2/schedule/internal_Node.hpp
...t_adapter_python/graph/PyOrientationConstraint.hpp
..._adapter/src/rmf_fleet_adapter/make_trajectory.cpp
..._rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observer.hpp
...f_fleet_adapter/src/read_only/FleetAdapterNode.hpp
... and 1045 more

@luca-della-vedova
Copy link
Member Author

Update and tested against the office world with a speed limit as shown in the issue ticket.
The main part I'm not too sure of is the mock_traffic_light implementation since I'm not that familiar with the codebase, it looks right but I didn't know how to test it and I'm happy to revert it to an unimplemented + TODO state if necessary.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of minor comments

Yadunund
Yadunund previously approved these changes Nov 26, 2021
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova merged commit c08926c into main Nov 26, 2021
@luca-della-vedova luca-della-vedova deleted the feature/fleet_adapter_speed_limit branch November 26, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants