-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task redesign v2 pybind apis and fix task testcases #154
Conversation
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the bindings, and also for working on the tests 🙇
elif args.task_log: | ||
msg_type = RmfMsgType.TaskLog | ||
else: | ||
print('Error! No msg_type is selected. select one: \n', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important enough to change right now, but just a thought: Since we require exactly one of these to be selected, it would probably be more idiomatic to have them as a single positional argument instead of optional flags.
This PR is to add support for the new task apis for
rmf_fleet_adapter_python
, and to fix existing test cases for loop and delivery task requests.pybind11_json_vendor
https://github.com/open-rmf/pybind11_json_vendor for json type conversion is used here.Expand
rmf_fleet_adapter_python
BindingsConfirmation
andconsider_..._requests
, apifleet_state_update_period
andfleet_state_topic_publish_period
ConsiderRequest
functionFix Test cases for loop and delivery
rmf_fleet_adapter_python
:rmf_fleet_adapter
Additionally, a utility script is created to echo the rmf websocket msgs. Example: