Fix Compose Tasks #159
Merged
Fix Compose Tasks #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
mxgrey
requested changes
Jan 27, 2022
| if (on_cancel_json.is_array()) | ||
| std::vector<rmf_task_sequence::Phase::ConstDescriptionPtr> cancel = {}; | ||
| const auto cancel_it = phase_json.find("on_cancel"); | ||
| if (cancel_it != phase_json.end() && cancel_it.value().is_array()) |
There was a problem hiding this comment.
We should not silently ignore on_cancel if it doesn't map to an array.
We can skip adding the cancellation sequence, but let's at least add a message to the errors vector so that the operators can be informed of the issue.
mxgrey
approved these changes
Jan 27, 2022
|
...Although it might not hurt to issue some kind of error anyway, just in case the schema has been changed while the assumptions of this code fail to be updated. |
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phase descriptions to builder in task deserializer.