-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to update speed limits for lanes and publish LaneStates message #217
Conversation
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
rmf_fleet_adapter/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 17.61% 17.73% +0.11%
==========================================
Files 209 844 +635
Lines 19351 78180 +58829
Branches 9297 37564 +28267
==========================================
+ Hits 3409 13865 +10456
- Misses 12274 49387 +37113
- Partials 3668 14928 +11260
Flags with carried forward coverage won't be shown. Click here to find out more. |
@mxgrey if the changes here are good I can update the python bindings and try to get this merged for the release |
Requires: open-rmf/rmf_internal_msgs#43
This PR adds two new public APIs to
FleetUpdateHandle
void limit_lane_speeds(std::vector<SpeedLimitRequest> requests)
: To impose speed limits on lanes whereSpeedLimitRequest
is a pimpled class. I'm not sure if its better to have this as a class or define it as anunordered_map<std::size_t, double>
. Or even juststd::vector<rmf_fleet_msgs::msg::SpeedLimitedLane>
. Alternatively, would it be better to just acceptstd::vecotr<rmf_fleet_msgs::msg::SpeedLimitRequest>
and have a single API limit and remove lane speeds?void remove_speed_limits(std::vector<std::size_t> requests)
: To remove any imposed speed limitsAnytime lanes are open/closed or speed limits are changed, a
LaneStates
msg is published over/lane_states
topic.I've also updated the implementation in the legacy
full_control
adapter to include a subscription interface forSpeedLimitRequest
. It still publishes the/closed_lanes
topic which is technically deprecated by the newer/lane_states
that includes speed limited lanes.TODO: Update python bindings once CPP API passes review.