Fix embedded asset path panic #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
reuben-thomas
pushed a commit
to reuben-thomas/rmf_site
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Reuben Thomas <reubenthomas123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Fixes #208.
Fix applied
This is the upstream bug that tracks the reason for our panic bevyengine/bevy#10377.
It has been fixed and released in 0.13 but we are on 0.12 as of now. As much as I'm always a big fan of updating we are cannot do it quite yet until
bevy_polylineandbevy_infinite_gridare updated, and they seem to always lag about 1 version of bevy.Luckily there seems to be a workaround in bevyengine/bevy#10377 (comment) that we can use until we migrate.
To test:
ros2 run rmf_site_editor rmf_site_editor.Note that I could only test on Linux, if anyone could test on Windows that would also be great but since this is quite severe I wouldn't necessarily hold that as a blocker.
It should panic without this PR and work fine with it.