Handle geometry collections #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Yadunund
approved these changes
Mar 8, 2024
|
@arjo129 can you ensure commits are signed? |
I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
arjo129
force-pushed
the
arjo/fix/mapgen_error
branch
from
5274edf
to
7a18141
Compare
xiyuoh
pushed a commit
that referenced
this pull request
Jun 4, 2024
I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Yadunund <yadunund@openrobotics.org> (cherry picked from commit f353f15)
luca-della-vedova
pushed a commit
that referenced
this pull request
Nov 8, 2024
I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
added a commit
that referenced
this pull request
Nov 8, 2024
* Fix MultiPolygon not iterable (#496) Signed-off-by: Xiyu Oh <xiyu@openrobotics.org> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Handle geometry collections (#476) I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Xiyu Oh <xiyu@openrobotics.org> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Xiyu <xiyu@openrobotics.org> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Yadunund <yadunund@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH.