Adding delete button to lift table #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR! I gave it a quick spin and two main comments:
- Can we have the delete button to be just
Deletewithout the...? The...imply that a new dialog is opened but it's not the case for deleting a lift. - We should probably do some further cleanup when a lift is deleted. Specifically, I noticed that the
lift_cabinwaypoint property is kept which is not ideal:
Edit I also forgot that for DCO to pass we need the commits to be signed, can you do that and force push your earlier commit as well?
TanJunKiat
force-pushed
the
feature/lift_delete_button
branch
from
a032bb3
to
f5d1381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
This PR is to add a delete button in the Lift table in the Traffic editor.
It is a minor feature that just convenience the usage of the Traffic editor.