-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event based infrastructure state update #68
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
This PR is now ready for review.
The main cost will be a larger payload on the rviz marker topic since we publish the whole state. The CI failure seems due to |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
I'll temporarily mark this as draft while I figure out what to do with it. The changes are not necessary anymore now that the event based logic was reverted in |
New feature implementation
Implemented feature
Part of open-rmf/rmf_simulation#114, to make the visualization more scalable for larger facilities.
Implementation description
This PR changes the
rmf_visualization_building_systems
to work with doors and lifts only publish an update when a new subscriber is detected or a state change takes place.This required a few changes:
Marked as a draft as I work on the PRs across the other repositories and make sure they all work well together.