Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Need mobile nav menu #866

Closed
1 of 2 tasks
bdougie opened this issue Feb 11, 2023 · 9 comments
Closed
1 of 2 tasks

Feature: Need mobile nav menu #866

bdougie opened this issue Feb 11, 2023 · 9 comments
Assignees
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. 👀 needs triage released on @beta
Milestone

Comments

@bdougie
Copy link
Member

bdougie commented Feb 11, 2023

Type of feature

🍕 Feature

Current behavior

When highlights are added we need to add hamburger menu or similar.

Screen Shot 2023-02-11 at 7 08 59 AM

Suggested solution

Probably dropdown hamburger or whatever the kids are doing.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added 💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. 👀 needs triage labels Feb 11, 2023
@bdougie bdougie added this to the Papercuts milestone Feb 11, 2023
@bdougie bdougie assigned bdougie and unassigned bdougie Feb 21, 2023
@getaheaddev
Copy link

This is what we currently have. @bdougie did you say "no" to having a hamburger menu?

[Figma File]

@bdougie
Copy link
Member Author

bdougie commented Mar 18, 2023

The mobile menu should place all menu items on its own row and allow wrapping when it gets more than 4 or 5 items.
Screen Shot 2023-03-17 at 8 02 25 PM

@bdougie bdougie removed their assignment Mar 18, 2023
@nworiekingslee
Copy link
Contributor

Can I take this?

@nworiekingslee
Copy link
Contributor

Screenshot 2023-03-19 at 00 06 22

@bdougie

@nworiekingslee
Copy link
Contributor

nworiekingslee commented Mar 18, 2023

Figma File

Is this on the Figma file? I would need to pick out the accurate spacing sizes and fontweight of the text.

The Figma link on the issue doesn't open

@takanome-dev
Copy link
Contributor

Screenshot 2023-03-19 at 00 06 22

Shouldn't the user avatar and the logo be aligned?

@nworiekingslee
Copy link
Contributor

Screenshot 2023-03-19 at 00 06 22

Shouldn't the user avatar and the logo be aligned?

True. I do the pix and push soonest

github-actions bot pushed a commit that referenced this issue Mar 21, 2023
## [1.36.0-beta.9](v1.36.0-beta.8...v1.36.0-beta.9) (2023-03-21)

### 🐛 Bug Fixes

* add a check for proper URL in avatarURL prop ([#1009](#1009)) ([a425279](a425279))

### 🍕 Features

* update top nav menu to be more responsive on mobile ([#1029](#1029)) ([90c1e4a](90c1e4a)), closes [#866](#866)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.36.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 22, 2023
## [1.37.0-beta.1](v1.36.0...v1.37.0-beta.1) (2023-03-22)

### 🧑‍💻 Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](#1028)) ([7b2bda2](7b2bda2))

### 🍕 Features

* add teams UI for the design system ([#994](#994)) ([499d08e](499d08e))
* added active styles to navbar links ([#1016](#1016)) ([c25c0a3](c25c0a3)), closes [#697](#697)
* update top nav menu to be more responsive on mobile ([#1029](#1029)) ([90c1e4a](90c1e4a)), closes [#866](#866)

### 🐛 Bug Fixes

* add a check for proper URL in avatarURL prop ([#1009](#1009)) ([a425279](a425279))
* center text inside upgrade access button ([#1027](#1027)) ([cf3f6cb](cf3f6cb)), closes [#1024](#1024)
* make delete standout ([#1026](#1026)) ([9c68287](9c68287))
* refresh highlights list on update and delete ([#1034](#1034)) ([bf2d951](bf2d951))
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.37.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 24, 2023
## [1.37.0](v1.36.0...v1.37.0) (2023-03-24)

### 🧑‍💻 Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](#1028)) ([7b2bda2](7b2bda2))

### 🍕 Features

* add teams UI for the design system ([#994](#994)) ([499d08e](499d08e))
* added active styles to navbar links ([#1016](#1016)) ([c25c0a3](c25c0a3)), closes [#697](#697)
* create collaboration Ui components ([#1006](#1006)) ([19ff5a7](19ff5a7))
* replace react toast to radix ([#933](#933)) ([3e000be](3e000be))
* update top nav menu to be more responsive on mobile ([#1029](#1029)) ([90c1e4a](90c1e4a)), closes [#866](#866)

### 🐛 Bug Fixes

*  updated footer file to update the year dynamically ([#1040](#1040)) ([c766d95](c766d95))
* add a check for proper URL in avatarURL prop ([#1009](#1009)) ([a425279](a425279))
* center text inside upgrade access button ([#1027](#1027)) ([cf3f6cb](cf3f6cb)), closes [#1024](#1024)
* close highlight dialog when clicking outside its container ([#999](#999)) ([1bc90bb](1bc90bb))
* make delete standout ([#1026](#1026)) ([9c68287](9c68287))
* make insights hub layout inconsistent on larger screens ([#1046](#1046)) ([daaf6d1](daaf6d1))
* refresh highlights list on update and delete ([#1034](#1034)) ([bf2d951](bf2d951))
* remove dialog layout overlap on single highlight view ([#1047](#1047)) ([ea836e8](ea836e8))
* update avatar style to remain aligned with the input field ([#1037](#1037)) ([2374f20](2374f20))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.36.0-beta.9](open-sauced/app@v1.36.0-beta.8...v1.36.0-beta.9) (2023-03-21)

### 🐛 Bug Fixes

* add a check for proper URL in avatarURL prop ([#1009](open-sauced/app#1009)) ([a425279](open-sauced/app@a425279))

### 🍕 Features

* update top nav menu to be more responsive on mobile ([#1029](open-sauced/app#1029)) ([90c1e4a](open-sauced/app@90c1e4a)), closes [#866](open-sauced/app#866)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.37.0-beta.1](open-sauced/app@v1.36.0...v1.37.0-beta.1) (2023-03-22)

### 🧑‍💻 Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](open-sauced/app#1028)) ([7b2bda2](open-sauced/app@7b2bda2))

### 🍕 Features

* add teams UI for the design system ([#994](open-sauced/app#994)) ([499d08e](open-sauced/app@499d08e))
* added active styles to navbar links ([#1016](open-sauced/app#1016)) ([c25c0a3](open-sauced/app@c25c0a3)), closes [#697](open-sauced/app#697)
* update top nav menu to be more responsive on mobile ([#1029](open-sauced/app#1029)) ([90c1e4a](open-sauced/app@90c1e4a)), closes [#866](open-sauced/app#866)

### 🐛 Bug Fixes

* add a check for proper URL in avatarURL prop ([#1009](open-sauced/app#1009)) ([a425279](open-sauced/app@a425279))
* center text inside upgrade access button ([#1027](open-sauced/app#1027)) ([cf3f6cb](open-sauced/app@cf3f6cb)), closes [#1024](open-sauced/app#1024)
* make delete standout ([#1026](open-sauced/app#1026)) ([9c68287](open-sauced/app@9c68287))
* refresh highlights list on update and delete ([#1034](open-sauced/app#1034)) ([bf2d951](open-sauced/app@bf2d951))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.37.0](open-sauced/app@v1.36.0...v1.37.0) (2023-03-24)

### 🧑‍💻 Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](open-sauced/app#1028)) ([7b2bda2](open-sauced/app@7b2bda2))

### 🍕 Features

* add teams UI for the design system ([#994](open-sauced/app#994)) ([499d08e](open-sauced/app@499d08e))
* added active styles to navbar links ([#1016](open-sauced/app#1016)) ([c25c0a3](open-sauced/app@c25c0a3)), closes [#697](open-sauced/app#697)
* create collaboration Ui components ([#1006](open-sauced/app#1006)) ([19ff5a7](open-sauced/app@19ff5a7))
* replace react toast to radix ([#933](open-sauced/app#933)) ([3e000be](open-sauced/app@3e000be))
* update top nav menu to be more responsive on mobile ([#1029](open-sauced/app#1029)) ([90c1e4a](open-sauced/app@90c1e4a)), closes [#866](open-sauced/app#866)

### 🐛 Bug Fixes

*  updated footer file to update the year dynamically ([#1040](open-sauced/app#1040)) ([c766d95](open-sauced/app@c766d95))
* add a check for proper URL in avatarURL prop ([#1009](open-sauced/app#1009)) ([a425279](open-sauced/app@a425279))
* center text inside upgrade access button ([#1027](open-sauced/app#1027)) ([cf3f6cb](open-sauced/app@cf3f6cb)), closes [#1024](open-sauced/app#1024)
* close highlight dialog when clicking outside its container ([#999](open-sauced/app#999)) ([1bc90bb](open-sauced/app@1bc90bb))
* make delete standout ([#1026](open-sauced/app#1026)) ([9c68287](open-sauced/app@9c68287))
* make insights hub layout inconsistent on larger screens ([#1046](open-sauced/app#1046)) ([daaf6d1](open-sauced/app@daaf6d1))
* refresh highlights list on update and delete ([#1034](open-sauced/app#1034)) ([bf2d951](open-sauced/app@bf2d951))
* remove dialog layout overlap on single highlight view ([#1047](open-sauced/app#1047)) ([ea836e8](open-sauced/app@ea836e8))
* update avatar style to remain aligned with the input field ([#1037](open-sauced/app#1037)) ([2374f20](open-sauced/app@2374f20))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. 👀 needs triage released on @beta
Projects
No open projects
Development

No branches or pull requests

4 participants